You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsObsolete attribute message should take precedence over Obsolete attribute message.
When both IsObsolete and Obsolete attributes are defined on a function (such as for some deprecated LibG functions), the message for whichever attribute was processed last was assigned to the warning message on the node. As IsObsolete attribute is a custom attribute in Dynamo that supports localization for its messages, it should take precedence over the message for Obsolete attribute, which is non-localized. This PR makes this change so that all deprecated node warnings are localized appropriately.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
This PR introduces new feature code involve network connecting and is tested with no-network mode.
Release Notes
Make IsObsolete attribute message take precedence over Obsolete attribute message on nodes so that if IsObsolete attribute messages are localized, the localized version of the deprecated warning can be displayed for non-ENU locales.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the handling of deprecation messages so that when both IsObsolete and Obsolete attributes are applied to a method, the localized message from the IsObsolete attribute is always preferred. Key changes include introducing a flag to track the presence of IsObsoleteAttribute, updating the attribute handling logic to correctly prioritize messages, and adding comments to clarify the localization behavior.
Comments suppressed due to low confidence (2)
src/Engine/ProtoCore/FFI/CLRDLLModule.cs:1291
[nitpick] Consider adding an inline comment explaining the purpose of hasIsObsoleteAttribute to improve code clarity for future maintainers.
private bool hasIsObsoleteAttribute;
src/Engine/ProtoCore/FFI/CLRDLLModule.cs:1411
[nitpick] Consider refactoring the attribute assignment logic by isolating the handling of IsObsolete and Obsolete attributes into dedicated helper methods for improved clarity.
aparajit-pratap
changed the title
Favor IsObsolete attribute message over Obsolete attribute message
Make IsObsolete attribute message take precedence over Obsolete attribute message
Jun 11, 2025
github-actionsbot
changed the title
Make IsObsolete attribute message take precedence over Obsolete attribute message
DYN-9033: Make IsObsolete attribute message take precedence over Obsolete attribute message
Jun 11, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-9033
IsObsolete
attribute message should take precedence overObsolete
attribute message.When both
IsObsolete
andObsolete
attributes are defined on a function (such as for some deprecated LibG functions), the message for whichever attribute was processed last was assigned to the warning message on the node. AsIsObsolete
attribute is a custom attribute in Dynamo that supports localization for its messages, it should take precedence over the message forObsolete
attribute, which is non-localized. This PR makes this change so that all deprecated node warnings are localized appropriately.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Make
IsObsolete
attribute message take precedence overObsolete
attribute message on nodes so that ifIsObsolete
attribute messages are localized, the localized version of the deprecated warning can be displayed for non-ENU locales.Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of