| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:21:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=440.70563,conversation_content-fragment;desc="conversation_content fragment";dur=643.192453,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=368.006086,nginx;desc="NGINX";dur=0.770565,glb;desc="GLB";dur=101.616666
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Xm1mmq0KTP2xtq%2B%2BhU%2FaDhVDR7xvK%2BBaP%2BQjhxIaflNRFrtvWos%2FaYel5v6YbOaPELqrA4ayik%2F0OK5VJb7E%2Fo9FgHY5csYu4gxbyxBmHwxwYlQ%2B5%2BMycY6KgeP9SZQ%2BEHCeb0PNA9ioP7S9FVi2A25CE1%2BQXGlxYVdsryUchDcF95C3OaP77ZvOgm3eEkTQ39RyS5ite45iLdhqshpZybCBbEwq72DEDl3CEv4YVc%2Fyd%2BhwwlvgCtC9shOkvFadzJHxWVBrLWdHLZ8o4MuuTQ%3D%3D--aZ3OH6WjOvHXEmaG--mcgJGVz7ZzDg7ip%2F9p0ACQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.656989073.1753593663; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:21:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:21:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E404:363053:AF3E42:E98F9B:6885B73F
DYN-8302: Optimizing loading of icons and preview bubble. by reddyashish · Pull Request #16285 · DynamoDS/Dynamo · GitHub
github-actions
bot
changed the title
[Draft] Optimizing loading of icons and preview bubble.
DYN-8302: [Draft] Optimizing loading of icons and preview bubble.
Jun 10, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
reddyashish
changed the title
DYN-8302: [Draft] Optimizing loading of icons and preview bubble.
DYN-8302: Optimizing loading of icons and preview bubble.
Jun 18, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8302: Optimizing loading of icons and preview bubble. #16285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8302
reddyashish
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes icon rendering by setting bitmap scaling to low quality for node visuals and improves performance of preview bubbles by debouncing their initialization on mouse events. It also introduces toggling of panning mode via the middle mouse button in the workspace view.
- Apply low-quality bitmap scaling to default and dynamic node icons to reduce rendering overhead.
- Debounce preview bubble creation on mouse enter and cancel on leave to minimize unnecessary UI instantiation.
- Add middle-button handlers in
WorkspaceViewto toggle pan mode on press and release.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs | Added middle-button pan toggling logic in mouse down and release handlers. |
| src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs | Set low-quality bitmap scaling on multiple icons and implemented debounced preview bubble logic with initialization and cancellation methods. |
| src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs | Introduced DelayNodePreviewControl debouncer utility and wired up disposal. |
Comments suppressed due to low confidence (5)
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:1561
- [nitpick] Inconsistent use of
viewModel(field) andViewModel(property) can be confusing. Consider standardizing on theViewModelproperty throughout.
viewModel.WorkspaceViewModel.DelayNodePreviewControl.Debounce(300, DelayPreviewControlAction);
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:1561
- The new debouncing logic for preview bubbles isn't covered by existing tests. Consider adding unit or integration tests to verify timing, invocation, and cancellation behaviors.
viewModel.WorkspaceViewModel.DelayNodePreviewControl.Debounce(300, DelayPreviewControlAction);
src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml.cs:905
- Using
e.MiddleButtonto detect which button was pressed may not reliably capture the middle-button click; consider checkinge.ChangedButton == MouseButton.Middlefor clarity and correctness.
if (!ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Pressed)
src/DynamoCoreWpf/Views/Core/NodeView.xaml.cs:2144
- The previous check for
viewModel.IsTransientwas removed, so transient nodes may now show a preview unexpectedly. Re-add theviewModel.IsTransientcondition to disable preview during transient state.
ViewModel.WorkspaceViewModel.IsPanning;
src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs:592
- Initializing
ActionDebouncerwith a null callback may lead to null-reference errors if used before assigning a valid action. Consider providing a no-op default or delaying the instantiation until a callback is known.
= new Wpf.Utilities.ActionDebouncer(null);
zeusongit
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-8302
https://jira.autodesk.com/browse/DYN-8306
Based out of changes from #15763 and #15823.
Icon freezing was already implemented in Node to Code PR. For some generic icons, bitmap-scalingmode has been set to low quality.
For preview bubble, we will be initializing the preview control only if the mouse stays on the node for a short time. It also helps when users are navigating large graphs, preview control won't be initialized for the passing nodes.
All tests passing now.
Open workspace timings
Entry Christmas : before 16-17 secs, after this change around 15 secs.
500 List nodes: noticing a difference of around 3 secs differential.
Autodesk-Mars : before 30-35 secs, after this change around 30 secs.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Optimizing loading of icons and preview bubble.
Reviewers
@DynamoDS/eidos