| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 15:18:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=419.423421,conversation_content-fragment;desc="conversation_content fragment";dur=1005.48413,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=355.468457,nginx;desc="NGINX";dur=0.797932,glb;desc="GLB";dur=102.176036
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=K%2FCi13D8tCUSPEqWpL4JS3sIw0AwYnJw5IhpOX%2FhG9aURFUdy6WjpNK3FeH99cIYxmkETRE08opbHGMJTT8OvwhS8nwTQBJ9%2B8RvvYNETyVmB3IxfPCIhtzfM5CuzvsOpNw%2FYEOS6cHID9KSrsKhOipZwkIcvRnWviodcCpPmOHQDfN%2F2dAoxAFWQH5Gb7AAc%2FEl48qMRDv1Is6ogg9rN055FB4ibFOC6iS%2BdBWiLu%2FcG7iVWwm6TRzezUr9M60XQzLi7HBZ%2BzaBfBxmyeQ3rw%3D%3D--qh7iKUYfZd2TKwNm--y0VPdhxZ17DjdF3wRP67ow%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1063607278.1753629527; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:18:47 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:18:47 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8874:5FFA9:F7C4B5:144FDF0:68864357
DYN-8906 : introduce autocomplete search combo by BogdanZavu · Pull Request #16256 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8906 : introduce autocomplete search combo #16256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8906
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds an inline search box to the autocomplete combo and wires up filtering in the view model.
- Binds the combo’s ItemsSource to a filtered view and injects a TextBox as the search input.
- Implements
FilteredView,FilterLogic, and aSearchInputproperty in the ViewModel. - Updates the Modern theme’s ComboBox template and registers a new converter.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/NodeAutoCompleteViewExtension/Views/NodeAutoCompleteBarView.xaml | Swapped ItemsSource, added Font settings, and placed a TextBox in the ComboBox.Tag |
| src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs | Introduced FilteredView, FilterLogic, and SearchInput handling |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoModern.xaml | Extended ComboBox popup template to render the search slot |
| src/DynamoCoreWpf/UI/Themes/Modern/DynamoConverters.xaml | Added NullToVisibiltyConverter resource |
Comments suppressed due to low confidence (1)
src/NodeAutoCompleteViewExtension/ViewModels/NodeAutoCompleteBarViewModel.cs:200
- The new filtering logic in 'FilterLogic' and the SearchInput behavior lack unit tests—consider adding tests to verify filtering results across various inputs.
private bool FilterLogic(object item)
| if (FilteredView != null) | ||
| { | ||
| FilteredView.Refresh(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating SearchInput, the ViewModel should raise PropertyChanged for 'SearchInput' to notify any bound consumers of its new value.
Suggested change
| } | |
| } | |
| RaisePropertyChanged(nameof(SearchInput)); |
Copilot uses AI. Check for mistakes.
Positive FeedbackNegative Feedback
johnpierson
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, for the next pr getting the text box to be focused on keyboard entry will be cool.
also merged some typo fixes from copilot.
|
Had to build the pipeline manually , results here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Add a search box inside the combo box of the autocomplete new experience.
It needs a little bit more work but we'll follow up on this or another pr.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@DynamoDS/synapse
FYIs
@QilongTang