DYN-6409 [Approach 2]: Disable PM requests with no-network mode #16238

aparajit-pratap · 2025-05-22T02:39:37Z

Purpose

This approach is similar to #16191, except for initializing a custom HTTP client that returns a service unavailable response and injecting that into the PM client for all requests.

This depends on the version of PM client that has the changes in DynamoDS/PackageManagerClient#116.

Declarations

Check these if you believe they are true

Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
This PR introduces new feature code involve network connecting and is tested with no-network mode.

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

github-actions

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6409

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…yn-6409_2

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

zeusongit · 2025-05-23T17:11:37Z

I would vote for this approach, looks and works better IMO

Copilot

Pull Request Overview

This PR implements an offline (no-network) mode by propagating a NoNetworkMode flag through sessions, HTTP clients, core nodes, and UI view models to disable network operations when Dynamo is offline.

Introduce a NoNetworkMode session parameter and a helper/HTTP handler to intercept and block outgoing requests.
Inject the custom handler into the PackageManager client and pass the offline flag to disable PM operations.
Update core nodes and view models to guard against network calls and disable related UI commands.

Reviewed Changes

Copilot reviewed 23 out of 33 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/NodeServices/ExecutionSession.cs	Add `NoNetworkMode` key, `ThrowIfNoNetworkMode` helper, and a `NoNetworkModeHandler`
src/Libraries/CoreNodes/Web.cs	Guard `WebRequestByUrl` with `ThrowIfNoNetworkMode`
src/Libraries/CoreNodeModels/WebRequest.cs	Refactor `NodeDescription` attribute to use `nameof`
src/DynamoPackages/PackageManagerExtension.cs	Inject `HttpClient` with `NoNetworkModeHandler`, pass offline flag
src/DynamoPackages/PackageManagerClient.cs	Store `NoNetworkMode`, update constructor, clean up field usage
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs	Disable publish commands when offline
src/DynamoCoreWpf/ViewModels/Menu/PreferencesViewModel.cs	Expose `NoNetworkMode` property
src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs	Disable package manager menu commands when offline
src/DynamoCore/Models/DynamoModel.cs	Update documentation for `NoNetworkMode`
src/DynamoCore/Configuration/ExecutionSession.cs	Initialize `NoNetworkMode` in session parameters

Files not reviewed (10)

src/DynamoCore/DynamoCore.csproj: Language not supported
src/DynamoCoreWpf/DynamoCoreWpf.csproj: Language not supported
src/DynamoCoreWpf/Views/Menu/PreferencesView.xaml: Language not supported
src/DynamoMLDataPipeline/DynamoMLDataPipeline.csproj: Language not supported
src/DynamoPackages/DynamoPackages.csproj: Language not supported
src/DynamoPackages/Properties/Resources.Designer.cs: Language not supported
src/DynamoPackages/Properties/Resources.en-US.resx: Language not supported
src/DynamoPackages/Properties/Resources.resx: Language not supported
src/NodeServices/DynamoServices.csproj: Language not supported
src/NodeServices/Properties/Resources.Designer.cs: Language not supported

Comments suppressed due to low confidence (5)

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs:455

The previous check for Selection.Count > 0 was removed, causing this to return true when the selection is empty (since All is vacuously true). Reintroduce the count check to prevent publishing with no selected nodes.

return DynamoSelection.Instance.Selection.All(x => x is Function) && AuthenticationManager.HasAuthProvider && !Model.NoNetworkMode;

src/NodeServices/ExecutionSession.cs:2

[nitpick] Remove the unused System.Collections.Generic using directive to reduce clutter.

using System.Collections.Generic;

src/Libraries/CoreNodes/Web.cs:16

Add a unit test to verify that WebRequestByUrl throws the expected InvalidOperationException with the offline warning when NoNetworkMode is enabled.

ExecutionSessionHelper.ThrowIfNoNetworkMode();

src/NodeServices/ExecutionSession.cs:132

Add a unit test for NoNetworkModeHandler to confirm that SendAsync returns HTTP 503 with the expected JSON payload and reason phrase.

var json = "{\"success\":false,\"message\":\"Application is in offline mode\",\"content\":null}";

src/Libraries/CoreNodes/Web.cs:13

Add XML documentation to indicate that this method throws InvalidOperationException when running in offline mode via ThrowIfNoNetworkMode().

public static string WebRequestByUrl(string url)

src/NodeServices/ExecutionSession.cs

reddyashish

Looks good to me

aparajit-pratap added 13 commits April 28, 2025 09:21

initial commit

2dabdd1

fix merge conflicts

11953c9

fix resx files

4f32e6a

revert unchanged files

292930c

Merge branch 'master' of github.com:DynamoDS/Dynamo into dyn-6409

f458121

disable package manager link on nonetworkmode

1793679

revert unchanged file

0c71b76

update tests

cd5d310

review comments

be498b8

revert localized files

e971915

review comments

f0ce1e3

inject custom http client for no-network mode

3fe95ab

cleanup

89c0e5c

github-actions bot reviewed May 22, 2025

View reviewed changes

aparajit-pratap mentioned this pull request May 22, 2025

Add new GregClient constructor to accept custom http client DynamoDS/PackageManagerClient#116

Merged

4 tasks

aparajit-pratap marked this pull request as draft May 22, 2025 02:52

aparajit-pratap requested review from zeusongit, reddyashish, mjkkirschner and Copilot May 22, 2025 02:53

This comment was marked as outdated.

Sign in to view

Update src/NodeServices/ExecutionSession.cs

0152a5b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

aparajit-pratap requested a review from avidit May 22, 2025 13:49

aparajit-pratap added 2 commits May 22, 2025 12:43

refactor

465fab7

Merge branch 'dyn-6409_2' of github.com:aparajit-pratap/Dynamo into d…

2499515

…yn-6409_2

aparajit-pratap requested a review from Copilot May 23, 2025 02:14

This comment was marked as duplicate.

Sign in to view

Update src/Libraries/CoreNodeModels/WebRequest.cs

6af06b3

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

reference latest package mgr client package

60e6362

aparajit-pratap marked this pull request as ready for review May 28, 2025 16:23

aparajit-pratap added 2 commits May 28, 2025 12:23

Merge branch 'master' of github.com:DynamoDS/Dynamo into dyn-6409_2

c9f4ce5

resolve merge conflicts

6bf8e2e

aparajit-pratap requested a review from Copilot May 28, 2025 16:36

Copilot AI reviewed May 28, 2025

View reviewed changes

src/NodeServices/ExecutionSession.cs Outdated Show resolved Hide resolved

review comments

8465c48

aparajit-pratap mentioned this pull request May 28, 2025

DYN-6409: Disable PM requests with no-network mode #16191

Closed

9 tasks

add API to list

6528811

reddyashish approved these changes May 29, 2025

View reviewed changes

aparajit-pratap merged commit 5831a52 into DynamoDS:master May 29, 2025
27 of 29 checks passed

aparajit-pratap deleted the dyn-6409_2 branch May 29, 2025 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DYN-6409 [Approach 2]: Disable PM requests with no-network mode #16238

DYN-6409 [Approach 2]: Disable PM requests with no-network mode #16238

Uh oh!

aparajit-pratap commented May 22, 2025 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as duplicate.

Uh oh!

zeusongit commented May 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

reddyashish left a comment

Uh oh!

Uh oh!

Uh oh!

DYN-6409 [Approach 2]: Disable PM requests with no-network mode #16238

DYN-6409 [Approach 2]: Disable PM requests with no-network mode #16238

Uh oh!

Conversation

aparajit-pratap commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Declarations

Release Notes

Reviewers

FYIs

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as duplicate.

Uh oh!

zeusongit commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

reddyashish left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aparajit-pratap commented May 22, 2025 •

edited

Loading