You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New key handling logic for Enter and arrow keys isnβt covered by existing tests. Please add unit or integration tests to verify navigation index changes and that events are marked as handled.
The reason will be displayed to describe this comment to others. Learn more.
Thereβs repeated e.Handled = true; in each case branch. Consider using a single flag to mark handled once or consolidate common logic after the switch to reduce duplication.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Handle enter and arrow keys in the new autocomplete. For the old one the improvement is included in this pr.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Addition of keyboard navigation in the Node AutoComplete bar.
Reviewers
@DynamoDS/synapse