You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplifies these changes but retains 20 -25% performance improvement for headless graph load time. Note that this % does not improve load time of graphs in Dynamo UI significantly, but it will be valuable for headless use cases.
cache category name - it does not look like ZT categories change since they use either the class name or the compiled attribute. So these seem safe to cache.
Note that this % does not improve load time of graphs in Dynamo UI significantly, but it will be valuable for headless use cases.
Curious why this doesn't have much performance impact in Dynamo UI?
I should have been more clear with numbers.
The mars graph v3 loads on my machine with no changes in ~1000ms (headless)
it loads with category caching in ~900 ms (headless)
it loads with category caching and assembly.Load changes in ~800ms (headless)
The mars graph v3 loads with UI in 30000ms - so the small number of ms saved here just make no discernable difference - the time is dominated by UI rendering/xaml loading etc.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
based on changes in:
#15834
simplifies these changes but retains 20 -25% performance improvement for headless graph load time. Note that this % does not improve load time of graphs in Dynamo UI significantly, but it will be valuable for headless use cases.
Assembly.Load
which internally caches if an assembly is already loaded - confirmed this is the case here:https://github.com/dotnet/runtime/blob/main/src/coreclr/vm/appdomain.cpp#L2554
I verified the 20% number using the mars v3 graph. (~700 nodes)
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
improve graph open time in headless contexts.