You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow tests to run against ASM231. The latest release of ASC is installed on the new build machines and we will start to run all tests against ASM231 after we migrate.
split DynamoCoreWpfTest into three assemblies. The last 400 tests or so in this assembly started to fail consistently when running against ASM231. It looks like Wpf fails to load resources and then crashes so I guess something is leaking. I have not been able to figure it out so far. I can make it work again if I disable any 30% of the tests in the assembly. I decided to split the assembly into three assembly's for now and it seems to make it very stable. I have seen these crashes before but they have been sporadic.
LGTM, although does this mean that we will have to split the tests again as we reach a certain number of tests in a single project?
I think this is related to WPF in this case. We do have issues with resource leaks that needs to be fixed at some point. But in general, I do think it is better to have a larger number of but smaller test assemblies so we should not be afraid to create new ones.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Purpose
This pull request does:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of