| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:31:18 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=412.006475,conversation_content-fragment;desc="conversation_content fragment";dur=876.594595,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=330.895147,nginx;desc="NGINX";dur=0.621563,glb;desc="GLB";dur=101.646551
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CVpnlR83iOuqOQiRgtX5%2Bey5vhQLHDR6Hy5RrHsxWfu5Xn4w8i1Hj8P%2BPFm%2Fgtx7flPLkFLgX0rs%2FtzSLOw1uOsfS8sDmYiYk03yoFExVqGtPNr6E7cte75T381EFEA%2FVznNIfvvMN3zl0IUAGEwlrP8qWDR3XEUz6MbvechsAc8x%2BvUmQjRD4mWcJDDyZL7vEYUFJ83Ljq%2B0peC0eB%2B2kNmV7jWZN8f6uWZMNYw6yf0Hh0jhqymu2XK0rx4%2B9pLsj1PGCIHTt%2F5pfogCjNmAw%3D%3D--e6Uobsw3hgSzxNSU--uoWMy7GEfqJqeFNLJkmSPQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.50616726.1753561877; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:31:17 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:31:17 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E9DC:138BF2:8D6BD1:B6D6F1:68853B15
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character by johnpierson · Pull Request #15762 · DynamoDS/Dynamo · GitHub
avidit
changed the title
Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
DYN-8163 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
Jan 17, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
johnpierson
changed the title
DYN-8163 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
Jan 17, 2025
johnpierson
changed the title
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
Jan 17, 2025
johnpierson
changed the title
DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character
Jan 17, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character #15762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
johnpierson
merged 8 commits into
DynamoDS:master
from
johnpierson:johnP_noteBulletModifications
Jan 17, 2025
Merged
DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character #15762
johnpierson
merged 8 commits into
DynamoDS:master
from
johnpierson:johnP_noteBulletModifications
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
approved these changes
Jan 17, 2025
|
Thanks @johnpierson We usually put Jira issue number at the beginning of PR title so that internal automation can link the PR to the issue, would you do that when you are aware of the issue number? |
|
Will do. Thanks for letting me know!
…On Fri, Jan 17, 2025 at 8:08 AM Aaron (Qilong) ***@***.***> wrote:
Thanks @johnpierson <https://github.com/johnpierson> We usually put Jira
issue number at the beginning of PR title so that internal automation can
link the PR to the issue, would you do that when you are aware of the issue
number?
—
Reply to this email directly, view it on GitHub
<#15762 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VBHJCQQQY5ZYJYH3BL2LEMGXAVCNFSM6AAAAABVMDULJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGU3TANJSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
For multiple JIRA tickets, how would that work? |
avidit
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8163
UI Smoke TestsTest: success. 11 passed, 0 failed. |
johnpierson
changed the title
johnpierson
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8164
johnpierson
changed the title
|
Ok, I think I managed to get everything correct. Sorry about that @QilongTang |
|
Cool side note on this, it allows for the user to disallow bullets with shift+enter, like word does |
QilongTang
approved these changes
Jan 17, 2025
|
Oops, another tip @johnpierson Please wait for all the PR checks to finish before merging. In this case, the Dynamo SelfServe check is pretty important to make sure any new PR does not bring additional regression to master branch. |
|
oh darnit. sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Allows for the user to use underscore character in notes again. Also adds the numpad minus key for bullet completion
Purpose
This PR allows the user to add underscore "_" character in notes again. It also adds the ability for the numpad "-" symbol to be used as a bullet item.
Previous interactions:
Proposed:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang @reddyashish
FYIs
@achintyabhat @avidit