| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:11:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=328.261863,conversation_content-fragment;desc="conversation_content fragment";dur=507.154838,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=228.194186,nginx;desc="NGINX";dur=1.102254,glb;desc="GLB";dur=101.839164
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=iwfgLpxjar6EuLOS2GbAGlI7iwCzxhkvZ2tWw2IFOUN9V3LyG4TSJj8jlLiMHOO%2BRT1LVZyBqOMGc5ep7FetrTNniyqrBIWaYF9e1u46Pd38fZAOeKT3Z3o38Ep3mxJm68u%2Bq7THsbZ5HMsiXoJmf3vb3rOX%2BoNtLI6a8XhRgzFBrAYXb9sb4HuqhuikM2CTPvTgXZqlb1T17mbNimGmFDefGSKSFrBhHDBHkiNdpJTLIdo%2FUpKtWO8X%2Brvj3q76pkp3W9Y8mOiTp0hQ999jcg%3D%3D--jAiJ%2Fo6PhV0J2Xrb--TSMz1JmkC6MEzybb8gchgA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.480732269.1753593068; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:11:08 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:11:08 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E1AC:3467EF:AE4637:E84841:6885B4EC
Fix Geometry.IsAlmostEqualTo Sample by johnpierson · Pull Request #15738 · DynamoDS/Dynamo · GitHub
QilongTang
added
DNM
Do not merge. For PRs.
and removed
DNM
Do not merge. For PRs.
labels
Jan 7, 2025
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Fix Geometry.IsAlmostEqualTo Sample #15738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 3 commits into
DynamoDS:master
from
johnpierson:fix_geometryIsAlmostEqualSample
Jan 10, 2025
Merged
Fix Geometry.IsAlmostEqualTo Sample #15738
QilongTang
merged 3 commits into
DynamoDS:master
from
johnpierson:fix_geometryIsAlmostEqualSample
Jan 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the sample's description was a verbatim copy of Vector.IsAlmostEqual to. FYI @Amoursol
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
approved these changes
Jan 7, 2025
|
Nice fix. Please hold on merging this PR since Morpheus team is updating localization pipeline and process, will come back to this |
QilongTang
added
DNM
|
@johnpierson Now that node help localization pipeline changes are done, would you update this PR to aim the file under |
|
Will do!
…On Thu, Jan 9, 2025 at 3:56 PM Aaron (Qilong) ***@***.***> wrote:
@johnpierson <https://github.com/johnpierson> Now that node help
localization pipeline changes are done, would you update this PR to aim the
file under en-US folder instead of root folder?
—
Reply to this email directly, view it on GitHub
<#15738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADYD5VHLXN5BJJPJMYBUEVL2J35DVAVCNFSM6AAAAABUJEYSM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRGQYDGNZRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
QilongTang
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
To fix the Geometry.IsAlmostEqualTo sample. The description was a copy of Vector.IsAlmostEqualTo
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
N/A
Reviewers
@achintyabhat
FYIs
@Amoursol