| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=302.190666,conversation_content-fragment;desc="conversation_content fragment";dur=624.343695,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=305.847118,nginx;desc="NGINX";dur=0.832034,glb;desc="GLB";dur=101.21006
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=SqIwOOEe1Bdl5bDgrjdrWWE1KaZ9AG3mPbtop3WF4O%2Fa26HUV6tOkL1djsU77CHCzm9PRVi3w3ncI6M1xsslX7isnMNBaS3JlL1y9h6YEgJ4pdTHv1ylD009yqGZrijD9TN6xIUrrXmVJn%2BqJwf545vUENPdyhf4B0WJs6Cu9zQipnFYcbMTOIgksDXDYon8VnYSU6t93CEm0ro9bLA7ASR1SgNHA0NcnM2x566AGILdmoht7kHeGowoVdyCWmi1qPzxScgBvfImDC%2BYiGeXaA%3D%3D--RfnF8zqWnEadA%2FDJ--aDpgcYREPGkqrdWm4ymmaQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1014461588.1753593154; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EE32:5FFA9:AF582D:E9646B:6885B542
DYN-7435 Corrupted Chars ON CHS OS by RobertGlobant20 · Pull Request #15699 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7435 Corrupted Chars ON CHS OS #15699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 3 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7435-CorruptedChars-CHS-OS
Dec 5, 2024
Merged
DYN-7435 Corrupted Chars ON CHS OS #15699
QilongTang
merged 3 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7435-CorruptedChars-CHS-OS
Dec 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a Windows 10 OS installed in Chinese Traditional if you open DocumentationBrowser several times for each node in the workspace, the DocumentationBrowser starts to show weird characters and the html layout seems different, this was happening due that the Md2Html.Convert and Md2Html.Sanitize methods were not executed, after my fix now they were executed but was still showing weird characters (due that Md2Html encoding was in Chinese Traditional). Then for fixing this problem I had to encode the info using base64 and decoded when is needed. There was a freeze reported in the Jira task but I was not able to reproduce it after my fix.
fixing bug that was generating a infinite loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7435
|
This is a GIF showing the behavior BEFORE my fix. |
|
This is a GIF showing the behavior AFTER my fix |
QilongTang
approved these changes
Dec 5, 2024
|
LGTM, Send this to @sm6srw to also review. |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
Due that FeatureFlags is using CLIWrapper as a Base Class my changes related to decoding base64 data were crashing the FeatureFlags.exe process and several tests were failing. Then I've added a extra default parameter in the GetData method so it will know if the data needs to be decoded or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Fix for not showing weird characters in DocumentationBrowser in a CHS OS
When using a Windows 10 OS installed in Chinese Traditional if you open DocumentationBrowser several times for each node in the workspace, the DocumentationBrowser starts to show weird characters and the html layout seems different, this was happening due that the Md2Html.Convert and Md2Html.Sanitize methods were not executed, after my fix now they were executed but was still showing weird characters (due that Md2Html encoding was in Chinese Traditional). Then for fixing this problem I had to encode the info using base64 and decoded when is needed.
There was a freeze reported in the Jira task but I was not able to reproduce it after my fix.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix for not showing weird characters in DocumentationBrowser in a CHS OS
Reviewers
@QilongTang
FYIs