| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 15:19:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.530035,conversation_content-fragment;desc="conversation_content fragment";dur=749.77314,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=254.132806,nginx;desc="NGINX";dur=1.337305,glb;desc="GLB";dur=100.709243
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jUUMDtD1ryKhTW5jatNW0ZU7ZgzdkxPVtgi2LvCRQtsndWtyNDx4RYQc1BccPh1OqbySvdsaiIXfljujgUs69aSKtiGiygRFpblpLn3bDptP5eO%2FhRNjWuWdLRJx5kMRVVfpfYXGeTX5r01v0cvXfqBOIKAMVi23L5yMxZJz%2F6pyoq0OaQqQoKusLEEXsYkLZHcXA7YrDuxXsKNcW5zlqWLkvd4JNX%2FH7YChDndjPTh3oHcs4ylg50Wv38t75Nw0M4KlYDhSf8BimYP8XIxluw%3D%3D--EPeqcd4cQOhMrp%2By--GrSzgubTtRrqv%2FEr%2BRcQ7Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.892410038.1753629553; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:19:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 15:19:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9CC8:93466:606688:7F0809:68864371
DYN-7945 pin home button when reducing library size by dnenov · Pull Request #15692 · DynamoDS/Dynamo · GitHub
QilongTang
changed the title
pin home button
DYN-7945 pin home button when reducing library size
Dec 2, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7945 pin home button when reducing library size #15692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pin the home button similar to the tab items
UI Smoke TestsTest: success. 11 passed, 0 failed. |
reddyashish
reviewed
Dec 2, 2024
| @@ -3085,6 +3088,28 @@ private void TabItem_MouseLeftButtonUp(object sender, MouseButtonEventArgs e) | |||
| this.dynamoViewModel.ShowStartPage = false; | |||
| } | |||
|
|
|||
| private void PinHomeButton() | |||
| { | |||
| const int FirstTabItemMinimumLeftMarginOffset = 230; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These constants are defined in UpdateWorkspaceTabSizes also, can you put them in the class and remove duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hesitant to touch the DynamoView class further, but thought about it too. That's now done, but I opted to keep the class variables close to the first place where they are used to reduce clutter.
|
LGTM with one comment. |
QilongTang
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7945
QilongTang
approved these changes
Dec 2, 2024
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Dec 5, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
We calculate and limit the leftmost position of the tabs in the Dynamo screen. After recently implementing a Home button, this PR ensures we follow a similar principle for pinning the Home button consistent with the Tab Items.
UI Changes
The
Homebutton will now only travel as far to the left as required to not overlap the button row.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of