You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#14514 Introduced a bug in which the linked helpdoc file appears concatenated at the end of the message info bubbles (See DereferencingNonPointer.html in the PR screenshots). This PR fixes that issue by properly sanitizing the message content and it also removes dangling references to a testing.html helpdoc that never existed.
@chubakueno Would you test after sanitizing the warning message, if clicking on learn more would still pop up the warning help content in the right side panel?
@chubakueno Would you test after sanitizing the warning message, if clicking on learn more would still pop up the warning help content in the right side panel?
Sure. Some warnings will no longer have the Learn more button because the testing.html link was removed, but others shouldn't be affected by the message sanitization (InfoBubbleDataPacket.ParseLinkFromText and InfoBubbleDataPacket.RemoveLinkFromText are not dependent on each other).
Duplicate warning after removal of the dangling testing.html link.
@chubakueno Would you test after sanitizing the warning message, if clicking on learn more would still pop up the warning help content in the right side panel?
Added tests to verify links are properly sanitized and extended the sanitizer to be more lenient (it will now accept everything until a space, newline, or end of string).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Purpose
#14514 Introduced a bug in which the linked helpdoc file appears concatenated at the end of the message info bubbles (See DereferencingNonPointer.html in the PR screenshots). This PR fixes that issue by properly sanitizing the message content and it also removes dangling references to a testing.html helpdoc that never existed.
Message with bug:
Message without bug in case of several warnings:
Message without bug in case of a single warning:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix stray helpdoc filename at the end of infobubble messages, remove dangling reference to inexistent helpdocs.
Reviewers
@QilongTang
@RobertGlobant20
FYIs
@avidit