| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7531 Catch WebView2 initialization exception #15685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7531
| catch (Exception ex) | ||
| { | ||
| Log(ex.Message); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea what exactly is crashing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @pinzart90 we should know why/what is crashing.
I have seen several times that when opening the latest Dynamo (3.4 or 3.3) the HomePage is NOT being shown and instead the old one is shown but I didn't know exactly why (although is not always happening).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertGlobant20 @pinzart90 I have removed the feature flag checking code for DynamoHome in 3.4 release, in that case, Dynamo home would always be the default. In the case it was not initialized correctly, then we display the legacy home. Adding such exception logging would help us understand why it was not working
| @@ -1427,21 +1427,28 @@ private void LoadHomePage() | |||
| { | |||
| if (homePage == null && (startPage != null)) | |||
| { | |||
| homePage = new UI.Views.HomePage(); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we handle the crash, will Dynamo be able to continue running ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the home page is not shown, can Dynamo still be used ?
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
Another thing to note here is that all of these CER reports are from 3.2.2 release, so I am not sure if the crash is still reproducible in latest Dynamo. |
|
Re-running the self CI on https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16867/ |
Purpose
Per CER report https://cer.autodesk.com/search/v2/buckets/52352002, add some code to prevent WebView2 initialization (Dynamo Home) crashing Dynamo.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Add some code to prevent WebView2 initialization (Dynamo Home) crashing Dynamo
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of