You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update enhances the snapping tolerance for connectors when interacting with the ConnectorAnchor.
A second, invisible connector has been introduced to handle MouseEnter and MouseLeave events. This invisible connector features a dynamic StrokeThickness that adjusts based on the current zoom level:
Zoom > 1: The StrokeThickness matches the visible connector's thickness (default: 3).
Zoom < 1: The StrokeThickness dynamically scales with the zoom factor, ensuring that the actual snapping area on the screen remains consistent regardless of the zoom level.
The StrokeThickness is doubled at smaller zoom factors to improve the responsiveness.
hi @ivaylo-matov Would love more time reviewing this PR, curious about the performance impact of the second connector here. Given this change would affect every connector, would you make some time comparison in bigger graphs?
@achintyabhat, Iβve implemented scaling functionality for the anchor, pin, and watch buttons. The size of these buttons now decreases as you zoom out with a non-linear scaling behavior. At Zoom = 1, the buttons retain their default size, but at smaller scales, the size gradually reduces to half of their original dimensions. IMO keeping the default button size at smaller scales looks odd. With this scaling behavior, the buttons remain comfortably clickable, even at zoom levels where the connector is no longer visible.
@QilongTang, I compared the opening times for Performance-Test.dyn against master and saw no degradation in performance.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR aims to address DYN-7839.
This update enhances the snapping tolerance for connectors when interacting with the ConnectorAnchor.
A second, invisible connector has been introduced to handle MouseEnter and MouseLeave events. This invisible connector features a dynamic
StrokeThickness
that adjusts based on the current zoom level:Zoom > 1: The
StrokeThickness
matches the visible connector's thickness (default: 3).Zoom < 1: The
StrokeThickness
dynamically scales with the zoom factor, ensuring that the actual snapping area on the screen remains consistent regardless of the zoom level.The
StrokeThickness
is doubled at smaller zoom factors to improve the responsiveness.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Improved connector snapping at lower zoom levels for Pin and Watch buttons.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov