| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:15:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=327.546134,conversation_content-fragment;desc="conversation_content fragment";dur=968.007255,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=257.459915,nginx;desc="NGINX";dur=0.941321,glb;desc="GLB";dur=101.945404
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=bRyIP%2FUSDwjW87wsEauEFdQQiMbWhDiiQJfb9pqeOFNb0LrYHXAfd4AJkyB65yOFoUZUMsx18bAXAE9qpOjtOCKYcASWTV0bjLqajw65X8q6YUywg3EF9aArSdPtzvqrvaedW7ICY6%2BreJHuVkWvneMCRcb22M18eIXebjhPdJdxv%2BVsVveBVFQessUAkiN84f2rFIZDcxA%2FlCkxnSIVR9ID750SAG3yqxKb2eCI0zImUnNCm2O%2BGxkTugmizCKCEVjm2xUitK3WaDLlcmYWPA%3D%3D--JDcsN3BeyrQ8aI8h--A15MRVkHPbWwQgSg6P4qRg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1136594523.1753593339; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:15:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:15:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AB84:3B05D7:AD947B:E7B926:6885B5FB
DYN-7693: Set geom scaling button setting to scale factor of current workspace model by aparajit-pratap · Pull Request #15589 · DynamoDS/Dynamo · GitHub
github-actions
bot
changed the title
Set geom scaling button setting to scale factor of current workspace model
DYN-7693: Set geom scaling button setting to scale factor of current workspace model
Nov 4, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7693: Set geom scaling button setting to scale factor of current workspace model #15589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7693
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Nov 4, 2024
|
|
aparajit-pratap
commented
Nov 4, 2024
| "Bindings": [], | ||
| "View": { | ||
| "Dynamo": { | ||
| "ScaleFactor": 10000.0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
QilongTang
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would you add a screen shot of the UX diff. I believe the controls on canvas would reflect the scaleFactor better is the change right?
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Nov 5, 2024
9 tasks
|
hey @aparajit-pratap can you explain what this change does to fix the issue? Is it just that we erroneously set the value to the scale factor raw value instead of the log of that value? Also - why do we do this - any idea what the benefit is? |
9 tasks
|
The geometry scale UI button reverts to the default setting every time I open the workflow. Is there a way of saving it with the dyn file. The geometry scale affects some of the functionality like Geometry.Intersect, so it is important to have the correct initial setting. Is there a way of setting the geometry scale from the API? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
There's a bug with the geometry scale UI button (in the top-right corner of the canvas) where it doesn't always reflect the correct scale factor setting in a workspace. It can be reproduced specifically on a fresh launch of Dynamo and upon opening a graph with a non-default scale factor setting (other than medium). This PR attempts to fix the issue.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed a bug with the geometry scale UI button where it doesn't always reflect the correct scale factor setting in a workspace.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of