You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My only concern is about all these geometry nodes' name lengths. I think sometime ago, @sm6srw had to convert long named files to be in hashed value. I forgot if C3D team or Revit team documented a limitation somewhere but I would encourage us using hashed value when we can.
@QilongTang not sure what the limit is... Currently the longest Mesh file Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg is shorter then other geometry help files like Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BySphereBestFit_img.jpg and Autodesk.DesignScript.Geometry.PanelSurface.ByCustomOrthogonalLattice_img.jpg.
@QilongTang I can't find the number yet that we convert files to hashed values. Since we are not longer then others I will merge and add this for follow up
Currently the longest Mesh file Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg is shorter then other geometry help files like Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BySphereBestFit_img.jpg and Autodesk.DesignScript.Geometry.PanelSurface.ByCustomOrthogonalLattice_img.jpg.
I wanted to add to this that right now we are building automations for checking these files and they currently need to follow naming of the DYN. So the . in the parentheses in these examples is causing a few issues at this time.
Autodesk.DesignScript.Geometry.Mesh.Translate(mesh.vector.distance)_img.jpg should read as ``Autodesk.DesignScript.Geometry.Mesh.Translate(mesh, vector, distance)_img.jpg`.
But if we were to use hashed values, we need to account for that in our automation as well. 🤔
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Documentation files are included for the new Mesh Nodes.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Documentation files are included for the new Mesh Nodes.
Reviewers
@LongNguyenP
FYIs
@Amoursol