You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of and older task that might not have been fully addressed the first time around - a link to the original PR can be found here: #14507
Context
Currently, only CustomFunctions were flagged up as 'Package' nodes in the UI. This PR attempts to add functions coming from Packages, regardless of their node type.
Changes (the gif is a bit long, sorry):
Limitations
In the example below, a node coming from the Forma package AssemblyName is not found in the list of packages insdie the NodePackageDictionary:
For this function to work correctly, package authors must make sure that the nodes are contained within the same assembly that the package will be listed under by the PackageExtension (please, correct me if I am wrong on this one).
For this function to work correctly, package authors must make sure that the nodes are contained within the same assembly that the package will be listed under by the PackageExtension (please, correct me if I am wrong on this one).
I think you mean For this function to work correctly, package authors must make sure that the nodes are contained within the assembly that marked as node library by package author.
When reviewing a different task, @aparajit-pratap has indicated that DynamoForma does not follow such structure and use a dedicated dll/helper to load all the nodes. Maybe that's the reason this is still going to break for Forma.
For this function to work correctly, package authors must make sure that the nodes are contained within the same assembly that the package will be listed under by the PackageExtension (please, correct me if I am wrong on this one).
I think you mean For this function to work correctly, package authors must make sure that the nodes are contained within the assembly that marked as node library by package author.
When reviewing a different task, @aparajit-pratap has indicated that DynamoForma does not follow such structure and use a dedicated dll/helper to load all the nodes. Maybe that's the reason this is still going to break for Forma.
Yes, exactly, apologies for the poor wording there. I hope this means that for the majority of the cases, the above should be sufficient.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QilongTang
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Purpose
Continuation of and older task that might not have been fully addressed the first time around - a link to the original PR can be found here: #14507
Context
Currently, only
CustomFunctionswere flagged up as 'Package' nodes in the UI. This PR attempts to add functions coming from Packages, regardless of their node type.Changes (the gif is a bit long, sorry):
Limitations
In the example below, a node coming from the
Formapackage AssemblyName is not found in the list of packages insdie theNodePackageDictionary:Conclusion
For this function to work correctly, package authors must make sure that the nodes are contained within the same assembly that the package will be listed under by the
PackageExtension(please, correct me if I am wrong on this one).Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
PackageNamecheck to mark a node as aCustomNodeIsCustomFuctionset to trueReviewers
@QilongTang
@zeusongit
@reddyashish
FYIs
@Amoursol