| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:33:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=278.196543,conversation_content-fragment;desc="conversation_content fragment";dur=664.922387,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=205.499426,nginx;desc="NGINX";dur=1.029357,glb;desc="GLB";dur=100.656387
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=yQ%2Fk2lR%2BJcpxJYVSMXp2z4DJD0236Ov74BfB0w9uZTppEumNCi1NnzLFkRbT%2B2SPcdoBHcN1yVzoj4G3h2RGnu4xkYqbziouGpVriPKFPcHlusOri0zpSl4P0fbMluCHAn11t91NSjJtHSQkOoaRLlwLw4lGlMkgGwigI7WZv7CsJZmW0rlmOIDMeMwsZaQOU7lX3bq7O%2FjXPkX9MUsw0WfQkr%2F4tn34VlzGivuPCctajRTxIso312gAdPQyvkkwtHTwL6MaFxKJf1UDGaVBiQ%3D%3D--OZ%2BfMu2k3wBR2067--aXI00VQo89%2Bg9kZt5SgvYQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1133574935.1753562019; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BD70:1C79A4:8D06E3:B6855C:68853BA3
DYN-7218 Revit Crash FileTrust Popup by RobertGlobant20 · Pull Request #15405 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7218 Revit Crash FileTrust Popup #15405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7218-Revit-Crash-FileTrustPopup
Jul 23, 2024
Merged
DYN-7218 Revit Crash FileTrust Popup #15405
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7218-Revit-Crash-FileTrustPopup
Jul 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under a specific case when the FileTrust Popup is visible and Dynamo is closed the Popup remains open then if the user clicks any button Revit crashes. For fixing this problem I've added a piece of code that will be closing the FileTrust Popup when Dynamo is closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7218
|
This GIF is showing the steps when Revit is crashing |
|
This GIF shows that after my fix is not crashing. |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Jul 22, 2024
| if(fileTrustWarningPopup != null && fileTrustWarningPopup.IsOpen) | ||
| { | ||
| fileTrustWarningPopup.IsOpen = false; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @RobertGlobant20 I understand the intention here, but again since the TrustWarningPopup being the only exception here (a specific close), I had to ask why it can't be closed like the other popups? We should have plenty other instances, e.g. incanvas search, notification center, guided tour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QilongTang I noticed that this code is not needed due that there is already funcionality closing the Popup when Dynamo is closed.
But related to your question, the fileTrustWarningPopup is begin hidden/shown depending if Dynamo window is Active or not, if you are aware about any problem in NotificationCenter or GuidedTour popups please let me know so I can investigate more about it.
I noticed that there is no need to close directly the fileTrustWarningPopup due that there is already functionality that is doing that. So I just had to set the FileTrustViewModel.DynFileDirectoryName for the SaveAs functionality and the Popup will be closed automatically when closing Dynamo.
QilongTang
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Fixing Revit Crash when closing the FileTrust Popup
Under a specific case when the FileTrust Popup is visible and Dynamo is closed the Popup remains open then if the user clicks any button Revit crashes. For fixing this problem I've added a piece of code that will be closing the FileTrust Popup when Dynamo is closed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Revit Crash when closing the FileTrust Popup
Reviewers
@QilongTang
FYIs