| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 13:33:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=342.235998,conversation_content-fragment;desc="conversation_content fragment";dur=960.99904,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=295.071969,nginx;desc="NGINX";dur=0.586379,glb;desc="GLB";dur=101.491464
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZIk5G94nKQxNylzkDakeHe9cam%2FA6CQqSmd5lVEsuDUlwsLe6ZPH7kmUQqBYRQHL%2FrHw8qBbOzC6NVT065Ti2f5UEZ6PABt2u28Evzs3P68HQgIu7bHFRb0%2BzDIHe0DbriYtn8fGLoYoE5Kt8Qx%2FtJsnFVPASlYBxbzY%2Bm8ozh9g4H%2FA5rdaai0rbW9KyyUDEE0WOqnA0WPm89PmHM%2BTvc67%2FeVQfomTfsvvWZUv%2Bo6iY2jMBdSCvIqK%2Bxb2nTpT51qXbx%2F4BHuMJWHQ04vMzw%3D%3D--1%2FKySIEITS2Eg1%2FO--bL6Q5yFrME%2Btq2lAWa7ERg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1627895763.1753623206; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 13:33:26 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 13:33:26 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A660:3ED739:E8989F:1327BBF:68862AA6
DYN-7139 WebView2 Crash when Opening Dialog by RobertGlobant20 · Pull Request #15361 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-7139 WebView2 Crash when Opening Dialog #15361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 6 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7139-WebView2Crash-OpenDialog
Jul 2, 2024
Merged
DYN-7139 WebView2 Crash when Opening Dialog #15361
QilongTang
merged 6 commits into
DynamoDS:master
from
RobertGlobant20:DYN-7139-WebView2Crash-OpenDialog
Jul 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebView2 was crashing when opening the OpenFile Dialog or the OpenTemplate Dialog, it was due that we were not using an async method for opening the file/template. Then I added an async method and will be called by the HomeApp component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7139
|
GIF showing that now WebView2 doesn't crash. |
QilongTang
reviewed
Jun 28, 2024
I was missing to implement the same fix for the next functionalities that also open a File OpenDialog from WebView2: - Open a Template (shortcut Ctrl + T) - Open (shortcut Ctrl + O) Finally I modified the functionality for using Commands instead of calling the method directly.
pinzart90
reviewed
Jun 30, 2024
Updating call to use a Dispatcher
|
Hi @RobertGlobant20 Notice the first PR check failed? Because you have added new public functions, you need to modify the file to add them to pass API break analysis |
Updating the public API so we won't get a API Break check.
Updating the public API so we won't get a API Break check.
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Jul 1, 2024
| @@ -2067,6 +2067,10 @@ Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultCommand.get -> Dyna | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultCommand.set -> void | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenTemplateDialogCommand.get -> Dynamo.UI.Commands.DelegateCommand | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenTemplateDialogCommand.set -> void | |||
| Dynamo.ViewModels.DynamoViewModel.ShowOpenDialogAndOpenResultAsyncCommand.get -> Dynamo.UI.Commands.DelegateCommand | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space included?
Removing extra space
QilongTang
approved these changes
Jul 2, 2024
QilongTang
pushed a commit
that referenced
this pull request
Jul 2, 2024
9 tasks
QilongTang
added a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
WebView2 was crashing when opening the OpenFile Dialog or the OpenTemplate Dialog, it was due that we were not using an async method for opening the file/template. Then I added an async method and will be called by the HomeApp component.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
WebView2 was crashing when opening the OpenFile Dialog
Reviewers
@QilongTang
FYIs
@reddyashish