CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:14:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=240.573815,conversation_content-fragment;desc="conversation_content fragment";dur=487.837832,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=229.117771,nginx;desc="NGINX";dur=1.276828,glb;desc="GLB";dur=102.000713
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=xwsZ2Qail0YPRCCkkst0a%2BZGPMvlL1J5z%2FA2DYANxKaobYGjBHR4S8QQD8rVlq%2FJMBwUG8jBi1vSaBMqfIqtekbJcBlzNhpkqI4srRx0u1D6wnZtkUISKHpdmt7cydn7%2BAfq5nA2Tv8i9%2F%2FnpYDx0aVijM9zav1WV6xutF5kv4Koctkc8FKVoDnPTASBWSY5AO3b52IxttnOdpZ2WuIQ2sEpOTtSZIcE%2BAfEsCaa1tZbS%2F8Yhi5uFLynvRpyQysV%2FpD4INSXUVN94%2B1nXGbM1A%3D%3D--fjlhkqvCfQnPtp%2Fm--%2Bk94N3or%2FjPAhMIMdeA8RQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1200152627.1753593241; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:14:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:14:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 99D8:3B05D7:AD69AC:E78154:6885B599
DYN-6991 crash report groups change by RobertGlobant20 · Pull Request #15239 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-6991 crash report groups change #15239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-6991-CrashReport-GroupsChange
May 23, 2024
Merged
DYN-6991 crash report groups change #15239
QilongTang
merged 2 commits into
DynamoDS:master
from
RobertGlobant20:DYN-6991-CrashReport-GroupsChange
May 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving groups inside Dynamo there was a crash but is not reproducible based in the information from the Report and Stack trace. Then with this validation we are validating that is not null and if is null then try to set the ViewModelBases again.
Adding code for just preventing the crash, there is no way to reproduce the steps done by the user and the report stacktrace doesn't give enough detail for this crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6991
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Dynamo Crash when the ViewModelBases is null
By checking the StackTrace of this report the System.Linq.ThrowHelper.ThrowArgumentNullException is send when trying to execute the next Linq instruction:
ViewModelBases.OfType<AnnotationViewModel>().ToList().ForEach(x => UpdateGroupCutGeometry(x));
So when ViewModelBases is null the exception is thrown.
I was trying to reproduce the behavior adding groups, group inside groups, moving the groups and nodes inside it but the crash was not generated then by checking the code the only way that ViewModelBases could be null is if the AnnotationModel doesn't contain the nodes/connectors in WorkspaceViewModel but this scenario was not reproducible.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Dynamo Crash when the ViewModelBases is null
Reviewers
@QilongTang
FYIs
@pinzart90 @avidit