| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:33:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=354.173848,conversation_content-fragment;desc="conversation_content fragment";dur=967.007681,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=343.45632,nginx;desc="NGINX";dur=1.334613,glb;desc="GLB";dur=102.102567
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=z9JRdBy6aCumtoxmMXuHtdTO2OtuU1HsNGxoUX5hoMvSMVQG9ssmMcMpNs4he14h6BxiI7CFO%2FB8LPaOCmWU0eaput0Zcr2EtGuHIXTbQ7VsUz%2FtjXgmbrf1ahJFViIJbgI1ka2t0D%2BhiRUCLTwUJfzA8VC6Tz3STOybKpFO1CUMZtWhN3tv5VnpNiMLdxb8LAjQ6IzJ8rLNGHTYkfYInKqO7yI3EeL8Qfejv2UWHU5HOMF5TchGCoMK1DGDEfoQfnV9DGfpTIpzJOmxNLZiJQ%3D%3D--OU9ZPjbpR1IhNQBh--CCki5tclN%2F4hLg%2BczbFRyg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1631577727.1753562003; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:33:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BD8A:3B05D7:8C1C5D:B596D3:68853B93
DYN-6927: Improvements to RemovePIIData API by reddyashish · Pull Request #15236 · DynamoDS/Dynamo · GitHub
github-actions
bot
changed the title
Improvements to RemovePIIData API
DYN-6927: Improvements to RemovePIIData API
May 22, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-6927: Improvements to RemovePIIData API #15236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6927
QilongTang
reviewed
May 22, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
May 22, 2024
QilongTang
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
QilongTang
reviewed
May 22, 2024
| //result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, creditCardPattern, ""); | ||
| result = Regex.Replace(result, websitePattern, ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @reddyashish So the trick is to just change the order of regex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main change is to use RemovePIIData(JObject jsonObject) API on the whole json object which will look for the regex pattern in the Views, Annotations etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, in the past we are running the regex against the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Task: https://jira.autodesk.com/browse/DYN-6927
Using the RemovePIIData(JObject jsonObject), we check for the regex patterns in specific parts like the VIew or Annotations section of the JSON to remove the personal sensitive data.
It should remove email pattern, SSN number pattern, credit card pattern, user directory pattern, IP address pattern, date patterns and website patterns.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
DYN-6927: Improvements to RemovePIIData API to accurately remove only the sensitive personal info.
Reviewers
@QilongTang @zeusongit
FYIs
@DynamoDS/dynamo