| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:22:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=320.788237,conversation_content-fragment;desc="conversation_content fragment";dur=753.964477,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=378.708927,nginx;desc="NGINX";dur=0.934998,glb;desc="GLB";dur=102.134954
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CaHKaK7ZzQPWvWZ32%2ByD8K4Sgtdi9H0HUgU3zqGVwqHg%2FQWKIIRXY1ArWJA1KvP3dVQO3xy6dTJ%2FUin5dn6EjumimT2uU44mHzpP4cevCbFV9mC3DOAvnOStG6rF%2FInfdVftdoRb4o3ORdnepi%2FkIRs8JPB06ctswiW%2Fap4KFhWXU0D15Put3klfyXy00GXMwkA3fnJkUedwIUT72%2B2doaJ43fSnh5Eqh3AbktGlqF1bdVtGIPFIM7EbWDJvrU8vY3iTjJ%2FCpxvjDMXKyGDXMQ%3D%3D--KNVUX0ON3P%2FxTNnZ--oQpAK3%2BilHVAJwoqlOjnPg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.59859856.1753618973; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:22:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:22:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C088:1AFF47:E070DD:1281A21:68861A1D
DYN-6874 Logging Packages Tour by RobertGlobant20 · Pull Request #15203 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-6874 Logging Packages Tour #15203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 1 commit into
DynamoDS:master
from
RobertGlobant20:DYN-6874-Logging-PackagesTour
May 13, 2024
Merged
DYN-6874 Logging Packages Tour #15203
QilongTang
merged 1 commit into
DynamoDS:master
from
RobertGlobant20:DYN-6874-Logging-PackagesTour
May 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due that the Packages guide doesn't have a Welcome popup (like the other guides) the Guide.Sequence starts at 1 (instead of 0) so I had to do a fix for calculating the number of steps correctly and modify the validation which is logging information when packages tour is completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6874
|
This is a GIF showing that when the Package tour is completed we will be logging the Completed status. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
reddyashish
approved these changes
May 10, 2024
zeusongit
reviewed
May 10, 2024
QilongTang
reviewed
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with remaining comment to be addressed
QilongTang
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Fixing Packages guide logging when is completed by user.
Due that the Packages guide doesn't have a Welcome popup (like the other guides) the Guide.Sequence starts at 1 (instead of 0) also the sequences are repeated (this allow to have conditional guide flow) so I had to do a fix for calculating the number of steps correctly and modify the validation which is logging information when packages tour is completed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Packages guide logging when is completed by user.
Reviewers
@QilongTang
@zeusongit
FYIs