You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user creates a input node (also known as a symbol node) in a custom node workspace previously the input node was empty. If left in this state and saved, the input symbol would be invalid as it did not have a default name, and would raise a warning and disallow save when next opened.
Just for the curious the input does have a default type though (var[]..[]).
To address this issue - now when an Input node is constructed now we set the name to a default (I'm just using input for now, which is what we use as a display name when the name is empty)
We now also show the type hint in default string to make the syntax more discoverable, as well as a comment - we could also show the default value syntax easily enough but I thought that might be info overload, as well as potentially having unintended consequences.
The reason will be displayed to describe this comment to others. Learn more.
So by default all input nodes will have the same name ?
so by default all input names of a custom node will have the same name. Do you think it might be worth create a unique name ?...maybe not
Also do output nodes not have the same issue ?
The reason will be displayed to describe this comment to others. Learn more.
So by default all input nodes will have the same name ? - yes
so by default all input names of a custom node will have the same name - yes - but note that there should not be inputNodes in home workspaces.
yes, by default they will have the same name, I considered using a part of the node guid so there's a very high chance the name would be unique - ie InputName_12345 or something like that.
Something to consider is that today, they already have the same name, it's just "".
Output nodes do not have any validation as far as I can tell.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When a user creates a
input node
(also known as a symbol node) in a custom node workspace previously the input node was empty. If left in this state and saved, the input symbol would be invalid as it did not have a default name, and would raise a warning and disallow save when next opened.Just for the curious the input does have a default type though
(var[]..[])
.To address this issue - now when an
Input node
is constructed now we set the name to a default (I'm just usinginput
for now, which is what we use as a display name when the name is empty)We now also show the type hint in default string to make the syntax more discoverable, as well as a comment - we could also show the default value syntax easily enough but I thought that might be info overload, as well as potentially having unintended consequences.
before:

after:


Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
By default creating inputs in a custom node will not put the custom node into an invalid state.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@Jingyi-Wen thoughts on this approach or what the default name / default string should be?