| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 11:38:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=288.392182,conversation_content-fragment;desc="conversation_content fragment";dur=808.032956,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=240.412235,nginx;desc="NGINX";dur=0.67635,glb;desc="GLB";dur=100.623386
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=0Vm6VhsVhgcgmVMunQ5OCcGAorcHm9isXr%2FZySJe87OFN%2B0IL5BZHOXv9G0Lbfuz8D74fepmroylX5KPxTIcRRfIxTX7HQmx4M6YteBvbG1ddOwEpivfh6Qig2%2FSXUEYQihIND%2Fo677%2BDSqy23mZJT34ujCNRsCJVLJBVvAxmZdDfBXgI6QUd3stHvz0N3VHnM6sPCwdBDnBI0UNwuc4kCnfqwOfhO%2FOE7V2wBeHJjovIde7P0jGkfbjXk9unNiQwPMFFnRAzC63GCr1GK8sJQ%3D%3D--dsvOhKlOCtX9fEwP--a4UiDsgQXZ8Fj5DSPClJog%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1932556410.1753616302; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:38:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 11:38:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CBB0:1369AB:DCC872:123094A:68860FAE
DYN-6794 python script editor convert legacy tabs to spaces by ivaylo-matov · Pull Request #15179 · DynamoDS/Dynamo · GitHub
avidit
changed the title
Dyn 6794 python script editor convert legacy tabs to spaces
DYN-6794 python script editor convert legacy tabs to spaces
Apr 29, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-6794 python script editor convert legacy tabs to spaces #15179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reddyashish
merged 4 commits into
DynamoDS:master
from
ivaylo-matov:DYN-6794-Python-script-editor-convert-legacy-tabs-to-spaces
May 6, 2024
Merged
DYN-6794 python script editor convert legacy tabs to spaces #15179
reddyashish
merged 4 commits into
DynamoDS:master
from
ivaylo-matov:DYN-6794-Python-script-editor-convert-legacy-tabs-to-spaces
May 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- button to convert legacy tabs to space indents - holds pace indentation strategy even in legacy code - test - clean - button icon is just a placeholder
avidit
changed the title
zeusongit
reviewed
Apr 30, 2024
src/Libraries/PythonNodeModels/Properties/Resources.Designer.cs
Outdated
Show resolved
Hide resolved
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
Apr 30, 2024
QilongTang
reviewed
Apr 30, 2024
QilongTang
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments
zeusongit
approved these changes
Apr 30, 2024
|
Waiting for PR checks before merging |
reddyashish
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the job again.
|
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/15991/testReport/ looks good. Only 1 test GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest has failed which was recently changed to fix the flaky behavior. |
|
Can I know what happen with the prevous script ? So it will automation or show the issue when user keep use old dynamo python script ? I don't want to see the same headache as Ironpython 2.7 converts to Cpython3, causing the sets to break. |
Hi @chuongmep My understanding is that there is no automation here, so if you open a legacy script, it should not be affected without user manually clicking on that new convert button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
PR to address https://jira.autodesk.com/browse/DYN-6794 & #15033 .
Added button in the Python script editor to convert tab indentations from legacy Python code to space indentations.
Includes test.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Added button in Python to convert tab indentations to space indentations so that users can run legacy code.
Icon for the convert button is a place holder.
PS: Tried a few options where we suppress the conversion to spaces in PythonIndentationStrategy but ultimately they all lead to problems beyond just pasting code with tab indentations. Preserving the current strategy and converting legacy code to the modern convention seem a better solution.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol