| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:25:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=356.025248,conversation_content-fragment;desc="conversation_content fragment";dur=1044.327985,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=362.727509,nginx;desc="NGINX";dur=0.688446,glb;desc="GLB";dur=101.813497
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=YGC8dXtqlj7TqJoVOl%2FgM6%2FirQ1RcDp%2FsTskPewhwydOfVib%2BftWYS7au7K4MPBGPRxL%2Fc%2Fe4%2BC29nLU3ninheHseciQmEDUz165tF6ZDCTgBD0s0JrV5h3i91gxlbzYKhBcUg%2BV9megExPVEJOh6YCj1KBW00INLHDMikEYXJsfneB3TQL0TD%2B2NQQQBi6t2Px9zQTeo%2BaU7BwLlD4n%2BMTz%2Bcp9%2B5FU5ZxRxQODnqeooP1K%2Bf6OJVynzI44S19ymo8T8FYoERKtFhX7a2EW4Q%3D%3D--Jbok9M0iIbRj8lSP--m1Xh11DsCd%2BPxr%2Fw%2FzQTmQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1676320966.1753619103; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:25:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:25:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9CBE:363053:E1787F:1293244:68861A9F
DYN-4344 hotkey to unpin all node previews by ivaylo-matov · Pull Request #15117 · DynamoDS/Dynamo · GitHub
avidit
changed the title
Dyn 4344 hotkey to unpin all node previews
DYN-4344 hotkey to unpin all node previews
Apr 29, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-4344 hotkey to unpin all node previews #15117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 15 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4344-Hotkey-to-unpin-all-node-previews
May 3, 2024
Merged
DYN-4344 hotkey to unpin all node previews #15117
QilongTang
merged 15 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4344-Hotkey-to-unpin-all-node-previews
May 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without hotkey some code might be redundant
all working
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
This is awesome :D Thanks so much @ivaylo-matov |
avidit
changed the title
reddyashish
reviewed
Apr 29, 2024
|
LGTM with one comment. |
QilongTang
approved these changes
Apr 30, 2024
|
@pinzart90 Were you trying to merge master into this branch, to solve the regression reported? |
Yes, but the problem still persists. It is actually caused by the new test. I am working on a fix and will push to this PR |
|
sorry for the delay... looking into it now. seem like the new test is causing the next two test to fail regardless of the order. All run okay if I move it last, but I assume this won't be acceptable? |
UnpinPreviewBubble() was not updating the nodeViewModel
|
hopefully the last commit will solve this regression 🤞 |
|
The failing test here is from GNM test suite [DynamoCoreWpfTests.GraphNodeManagerViewExtensionTests.ContainsEmptyListOrNullTest] which is flaky. @QilongTang good to merge this? |
reddyashish
approved these changes
May 3, 2024
|
Self serve passed on https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1439/ |
Good point, This one should be good to go from the last Dynamo Self Serve run, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.
Test also included.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Added functionality to unpin and collapse all preview bubbles. Implementation of menu item and hotkey (CTRL + K) to trigger the command.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol