| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 12:16:29 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=268.208572,conversation_content-fragment;desc="conversation_content fragment";dur=654.052912,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=243.955649,nginx;desc="NGINX";dur=1.146083,glb;desc="GLB";dur=100.157046
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ZRLYYKCMNjAHMUxTF1SA4LB%2Fi0c92yssdEPzL0soDi%2BUWDNlGPnx%2F986%2B4%2F6t52OmgN9O8j2jN3fOLRCMi%2B7qbtAgTyACjviJXPJfxoJr3Fk8z0PFmBUZUeoU4yAq4KxuwrzV8EDNVAQHi9vfnDOEhDdbbEnWMax8f1ZI4y5JM3%2FjpZi4WMNZdvy07vmfRURJeuXjrWbePHHqi2bRsmNhlIjQBQQ273fmSiW0mlbwcC9AEk5AxHYuI5FhhLLrqAfGYxdN50Np1QI1msKiAeneg%3D%3D--IsgjEen2Y0q4urVd--skrCwWDv5i1IyedIyDBoSQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2056351271.1753618588; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:16:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 12:16:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8876:2CB2E7:E0778A:127EE60:6886189C
DYN-4449 Undo in group casues weird visual artifacts by ivaylo-matov · Pull Request #15067 · DynamoDS/Dynamo · GitHub
QilongTang
changed the title
DYN-4449 fixed
DYN-4449 Undo in group casues weird visual artifacts
Apr 3, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-4449 Undo in group casues weird visual artifacts #15067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 3 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4449-Undo-in-group-casues-weird-visual-artifacts
Apr 3, 2024
Merged
DYN-4449 Undo in group casues weird visual artifacts #15067
QilongTang
merged 3 commits into
DynamoDS:master
from
ivaylo-matov:DYN-4449-Undo-in-group-casues-weird-visual-artifacts
Apr 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connectors in groups remain collapsed on undo
|
Will check the fail tomorrow morning.... |
second PR attempt
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
All looks okay now |
mjkkirschner
reviewed
Apr 2, 2024
| /// Consequently, if a group is collapsed and then moved, performing an Undo operation will not restore | ||
| /// the connector to its state at the time the move was recorded. | ||
| /// </summary> | ||
| private void SetCollapsedByNodeViewModel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like you could write a unit test for the Redraw method that makes sure IsCollapsed is true when it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see the test included. hope that's okay.
QilongTang
changed the title
QilongTang
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Undo in group causes weird visual artifacts. On undo connectors will be visible even though the group that they are in is collapsed. I added a method that that is executed on Redrawn and evaluates whether both nodes associated with connector are collapsed, if so, collapses the connector itself.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Connectors are only recorded in the Undo stack when they are connected. Consequently, if a group is collapsed and then moved, performing an Undo operation will not restore the connector to its state at the time the move was recorded. The new method evaluates whether both nodes associated with a connector are collapsed, if so, collapses the connector itself.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol