You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
changed the title
[WIP] DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag
DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag
Feb 7, 2024
@QilongTang did we want to hide the entire Experimental section also if we no longer have anything inside it? i.e. - it shows if we have something, is hidden if not?
@QilongTang did we want to hide the entire Experimental section also if we no longer have anything inside it? i.e. - it shows if we have something, is hidden if not?
@QilongTang did we want to hide the entire Experimental section also if we no longer have anything inside it? i.e. - it shows if we have something, is hidden if not?
@QilongTang did we want to hide the entire Experimental section also if we no longer have anything inside it? i.e. - it shows if we have something, is hidden if not?
Agreed, I think we will have more experimental features in the future, e.g. new App home
As far as I understand, this PR isn't doing it the way @Amoursol is suggesting. The display of the experimental expander purely depends on whether the feature flag is on or off, not on whether there are experimental features or not. I think the experimental section should be displayed based on whether NamespacesToExcludeFromLibrary is empty or not.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-6602 Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag.

Tested cases covering:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Make Dynamo TSpline nodes OOTB and hide experiment toggle under feature flag
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of