You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB
Release Notes
fix a bug where installing the ironPython package from the workspace references extension can add 2 ironPython items to the engine dropdown on python node.
so if we will support assembly isolation, then we could have the same pacakge but different versions loaded at the same time
So should we enforce uniqueness by appending the version to the engine name (internally at least)?
In the UI we could display the same name but tooltip would clarify which version. Or something like that ..
IMO we can improve this later, but I think it's fine to request that Python engines use unique names and can definitely be deferred until we enforce assembly isolation somehow.
I see some failures on master-5, but they don't seem to be related and they appear to just be new flakiness from moving to parallel tests - I see them on other PRs as well.
* remove IronPython code and extension (#14706)
* remove legacy completion provider
* remove
* remove obsolete -arguable
tests seem to pass going to merge this and cherry pick to 3.0
* fix Dyn-6060 - duplicate python engine names (#14731)
merging this and making a cherry pick.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR replaces:
mjkkirschner#5
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
fix a bug where installing the ironPython package from the workspace references extension can add 2 ironPython items to the engine dropdown on python node.
Reviewers