You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user deletes a node that has the node autocomplete menu open, it leaves the menu dissociated with the node and when a user clicks on any item on the menu, Dynamo crashed.
This PR fixes this case by closing the associated node autocomplete menu when the parent node is deleted.
On delete key press event any open node autocomplete menu will be closed.
avidit
changed the title
Fix crash when parent node is deleted while node autocomplete menu is displayed
DYN-6397 Fix crash when parent node is deleted while node autocomplete menu is displayed
Dec 8, 2023
Maybe try the self serve on master-15? Even after I update your branch with master, there are still a bunch failures.
Tried master-15 , but each run gets me a different result, not sure what the problem is, I will wait for the ongoing issue with async test runs to resolve.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avidit
changed the title
Purpose
https://jira.autodesk.com/browse/DYN-6397
When a user deletes a node that has the node autocomplete menu open, it leaves the menu dissociated with the node and when a user clicks on any item on the menu, Dynamo crashed.
This PR fixes this case by closing the associated node autocomplete menu when the parent node is deleted.
On delete key press event any open node autocomplete menu will be closed.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix crash when parent node is deleted while node autocomplete menu is displayed
Reviewers
@DynamoDS/dynamo