You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert change that was introduced to try and fix failing tests before. The change was a BeingInvoke wrap around a clean up of a property which was used inside async code. The use of the BeginInvoke was causing a crash in production code in Dynamo.
- disabled CancelCommandClearsAllData test as the command it is supposed to be testing currently is restricted under testing environment as it crashes master-15 (sequentially running of tests) because of thread affinity issue
I disabled CancelCommandClearsAllData test as the command it is supposed to be testing, is currently restricted under testing environment. It crashes master-15 (sequentially running of tests) because of thread affinity issue. So this test does not make sense at the moment.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Revert change that was introduced to try and fix failing tests before. The change was a
BeingInvoke
wrap around a clean up of a property which was used inside async code. The use of theBeginInvoke
was causing a crash in production code in Dynamo.This jira issue picks it up https://jira.autodesk.com/browse/DYN-6507?filter=-1
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@reddyashish
FYIs
@avidit
@mjkkirschner