Pm mypackages - cherrypick resources #14299

dnenov · 2023-08-22T10:44:18Z

Cherry-pick from #14198 to break it down into smaller chunks.

last part of the PR
resources and final cleanup

Purpose

This is a follow-up PR on the package integration PR. It builds on the continuous design guides as per this Figma link.

Even though a lot of areas have been improved, this is still work in progress. With the main skeleton of the solution in place, the major directions of work are:

design changes in Search for packages tab
design changes in Publish a package tab
design changes in My packages tab
design changes in Publish version tab

Screenshots

01 loading screen

02 discard loading timeout

03 package details extension interaction

04 package manager contents

05 package manager to preferences interaction

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated
This PR contains no files larger than 50 MB

Release Notes

Progression work on the Package Manager

interactions between different parts of the package manager and between package manager and preferences screen
added empty, loading, idle screens
work on the PacakgeDetailsExtension to allow hosting inside the PackageManager
misc refactor

Reviewers

@reddyashish
@QilongTang

FYIs

@Amoursol

- merging existing functionality for the package details extension

- added comment to the use of 'IsTabStop' inside the InstalledPackagesControl.xaml - public eventhandler made internal - framework element name equality check on longer relies on localized strings, using private readonly strings instead

- added resources for localization - package manager view final changes

…ources

- added test for InitialResultsLoaded - removed accidental code

- removed PackageManagerSearchPackagesControlName as no longer needed

- small update to the border thickness - comment added to the new copy-to-clipboard

src/DynamoCoreWpf/Properties/Resources.resx

chuongmep · 2023-08-22T15:18:32Z

I have a question, can we allow upload with version lower like nuget.org ?
Example : I publish new version :

2023.0.0
2024.0.0
And I need to upload new version update with number : 2023.0.1. I just want to confirm if I'm missing something with package manager.
Thank you.

src/DynamoCoreWpf/Properties/Resources.resx

src/DynamoCoreWpf/UI/Converters.cs

src/DynamoCoreWpf/Views/Core/DynamoView.xaml

QilongTang · 2023-08-22T17:15:21Z

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

@@ -2202,13 +2202,20 @@ private void DynamoViewModelRequestShowPackageManager(object s, EventArgs e)
                    WindowStartupLocation = WindowStartupLocation.CenterOwner
                };

+                // setting the owner to the packageManagerWindow will centralize promts originating from the Package Manager
+                dynamoViewModel.Owner = packageManagerWindow;


QilongTang · 2023-08-22T17:26:51Z

src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs

+        {
+            var tabName = Dynamo.Wpf.Properties.Resources.PreferencesPackageManagerSettingsTab;
+            var expanderName = Dynamo.Wpf.Properties.Resources.PackagePathsExpanderName;
+            PreferencesPanelUtilities.OpenPreferencesPanel(dynamoView, WindowStartupLocation.CenterOwner, tabName, expanderName);


Do we do this so it works in a localized environment? But I think it is the other way round right? It would fail that way, did I miss anything here

I can see that you are following an existing example, let's leave it for now

src/DynamoCoreWpf/Views/PackageManager/PackageManagerView.xaml.cs

QilongTang

LGTM with some comments

- removed redundant resource - public into internal

dnenov added 8 commits August 17, 2023 13:10

cherry-picking package details extension functionality

5d1a1b2

- merging existing functionality for the package details extension

Merge remote-tracking branch 'upstream/master' into pm-detailsextension

cc20c78

Comments

801528d

- added comment to the use of 'IsTabStop' inside the InstalledPackagesControl.xaml - public eventhandler made internal - framework element name equality check on longer relies on localized strings, using private readonly strings instead

resources added

6eed8c7

- added resources for localization - package manager view final changes

Merge remote-tracking branch 'upstream/master' into pm-cherrypick-res…

57704e0

…ources

test added

04011e8

- added test for InitialResultsLoaded - removed accidental code

removed PackageManagerSearchPackagesControlName from resources

cc58820

- removed PackageManagerSearchPackagesControlName as no longer needed

update to preferenceview

7d8f567

- small update to the border thickness - comment added to the new copy-to-clipboard