Purpose

I could not reproduce the crash seen in #14192 in master (2.19).

I did notice however that checking customNode outputs frequently throws thousands of exceptions and also fails to find results even when the type name is a valid type!

I've made two changes I think will improve the situation a small bit.

1. When we encounter a space in a custom node output port name, we just use the first word, it at least has a non zero chance of being a type name.
2. when we look for matching types we use the Type.Name instead of Type.ToString() ToString will also include rank, like var[]..[] - this is not a valid class name that can be found in the class table, and so we never make any matches with types that include rank. After this PR we'll better match different ranks of type, and also derived types.

Note how more valid results are returned in the tests I have updated. Also less exceptions are thrown, so the results are computed a bit faster.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated
• This PR contains no files larger than 50 MB

Release Notes

Return more results for object based node autocomplete when using custom node output ports.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of