| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 14:08:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=381.113861,conversation_content-fragment;desc="conversation_content fragment";dur=791.778164,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=312.663107,nginx;desc="NGINX";dur=1.131711,glb;desc="GLB";dur=101.089775
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=wYryMGh0R5SyijkMK%2BIOtgNuJ4qcPxS8RikAfRE0T6CXylPRcwdnBUhM6MOsUStWtjsmZ2h%2Bg50N3%2FjcgSy5VBjUBrSRdM4zqpzNzMXBQZAwirdJfdFFGbMFwKwZQHSelIY%2Bgw0ONrz633%2BOi2lJXM%2FFsJfaTYzK6A32wWb92LCzgNoGG2lXQnorYwhVV0bQb6sXrnxUddxKzg%2BpkD%2FH36xGSr2F7sdFLJvHYm7aG%2Bbp4z0S3RTNqUOiRwNZyvdiUTDvZ90ejDq2Nt4uPALuAQ%3D%3D--6O3sQxItih9L3C2d--%2BFM2S1H5f8eQhsfaMb4DQg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1606862493.1753625284; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 14:08:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 14:08:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C372:3C6DB4:57ABE3:740EDB:688632C4
feat(DYN-5976): add forward delete functionality by Enzo707 · Pull Request #14217 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
feat(DYN-5976): add forward delete functionality #14217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 2 commits into
DynamoDS:master
from
Enzo707:bugfix/DYN-5976/forward-delete-not-working
Aug 3, 2023
Merged
feat(DYN-5976): add forward delete functionality #14217
QilongTang
merged 2 commits into
DynamoDS:master
from
Enzo707:bugfix/DYN-5976/forward-delete-not-working
Aug 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Aug 2, 2023
| @@ -347,6 +348,7 @@ private void Browser_CoreWebView2InitializationCompleted(object sender, CoreWebV | |||
| //The default value of the zoom factor is 1.0. The value that comes from the slider is in percentage, so we divide by 100 to be equivalent | |||
| browser.ZoomFactor = (double)dynamoViewModel.Model.PreferenceSettings.LibraryZoomScale / 100; | |||
| browser.ZoomFactorChanged += Browser_ZoomFactorChanged; | |||
| browser.KeyDown += Browser_KeyDown; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please unsubscribe at protected void Dispose(bool disposing) function to avoid memory leak
|
@Enzo707 Can you take another look at DynamoDS/librarie.js#185? |
QilongTang
approved these changes
Aug 3, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
This PR implements the forward delete functionality as webview2 doesn't support Accelerator keys
DYN-5976
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Implements forward delete functionality for searchBar input in librariejs and the mechanism in dynamo to "binding" accelerator keys that are not supported in webview2.
In other words we track accelerator keys in Dynamo and use javascript dispatchEvent method to trigger the librariejs event that execute the forward delete method.
Reviewers
@QilongTang
FYIs
@RobertGlobant20