| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 02:17:36 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=346.95234,conversation_content-fragment;desc="conversation_content fragment";dur=957.839195,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=286.863345,nginx;desc="NGINX";dur=2.020525,glb;desc="GLB";dur=102.511515
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Z3ZRn0uQ6%2F1%2F%2BRsPeFbjzbLAGZ8vp%2FhUQ4kMeVxMFf3dtiZZrd%2BU8o9V26Xwi49rIpId9WKWiD95btHBY7EIT%2BAW403uuEKL84Q7c0TP3Ntt5d9vwr0BTc8Pl87UucAo3O1%2BeICbivgSTmttk58GXEa%2BSAlEvVLWZhpndyCygqmx0xDpwCPrh0rmXsVydwSHddDn0orv3T6rFDpqlr7UO6yqzBX8U3RYsnGJrhnHCDjtzW04Q%2B%2FroEfKN5SI2F%2FQyVtUou1txFUe%2Flx2wV022Q%3D%3D--yRB3yVBLBDsM%2FTJf--rJb24ag%2FPlxyZQb3zLaiPA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.589273520.1753669055; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:17:35 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:17:35 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A10E:3467EF:12BEEF7:18E237C:6886DDBF
DYN-6037 lucene overloaded nodes by RobertGlobant20 · Pull Request #14136 · DynamoDS/Dynamo · GitHub
avidit
changed the title
Dyn 6037 lucene overloaded nodes
DYN-6037 lucene overloaded nodes
Jul 7, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-6037 lucene overloaded nodes #14136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 4 commits into
DynamoDS:master
from
RobertGlobant20:DYN-6037-Lucene-Overloaded-Nodes
Jul 11, 2023
Merged
DYN-6037 lucene overloaded nodes #14136
QilongTang
merged 4 commits into
DynamoDS:master
from
RobertGlobant20:DYN-6037-Lucene-Overloaded-Nodes
Jul 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some nodes were missing for the search due that were overloaded so the same node was added several times in the search results without considering the parameters. The fix was indexing also the parameters so when executing the search we need to also match the parameters.
Fixing comment
|
This is a GIF showing the search results after my fix: |
QilongTang
reviewed
Jul 6, 2023
| if (e.Parameters == null) | ||
| return string.IsNullOrEmpty(parameters); | ||
| else | ||
| return e.Parameters.Equals(parameters); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put comments for this block, not too intuitive to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added more comments please let me know if the explanation is clear. Thanks
commit: 6bc39b7
Adding comments for explaining a piece of code.
avidit
changed the title
reddyashish
reviewed
Jul 10, 2023
| @@ -138,7 +143,8 @@ public enum IndexFieldsEnum | |||
| nameof(IndexFieldsEnum.Description), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the Enum name from IndexFieldsEnum to NodeIndexFields, as it is specific to that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've renamed IndexFieldsEnum to NodeIndexFields
commit: fab8b07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion, I just saw that the same enum property is used in PackageIndexFields also and one of the enum values is "Hosts". Not a big deal, you can revert this last name change if you want.
reddyashish
approved these changes
Jul 10, 2023
QilongTang
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
Renaming IndexFieldsEnum to NodeFieldsEnum.
|
@RobertGlobant20 can you check if the regressions are real? |
|
Failing test is a ASM loading exception on visualization tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Fixing Lucene search result for overloaded nodes.
Some nodes were missing for the search due that were overloaded so the same node was added several times in the search results without considering the parameters.
The fix was indexing also the parameters so when executing the search we need to also match the parameters.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixing Lucene search result for overloaded nodes.
Reviewers
@QilongTang @reddyashish
FYIs