| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 10:15:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=263.707679,conversation_content-fragment;desc="conversation_content fragment";dur=675.443456,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=257.826474,nginx;desc="NGINX";dur=1.401227,glb;desc="GLB";dur=101.353194
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Tsm5PhZMVofoFQTvrRT9whIuh%2BmRqudYfWbE1lWRUFn3pdxE3PsTzTx%2BVe%2B5dOaDU7D6nlbV1W%2FIYmeJK4rG8NVuq%2BQYF8B7qgVsP3D%2FmWoPhh6r9p3vmLzM5mCaerpKyS6XzEcBni9L3xvBIiNnkWh9vCQnTEGYHTth6AcRjpsZQD3meevlIYDYfPi5UaHfHkmclcLWCv%2FLqWl5fze1YXAwjm5G5mFFBcEOfSpEEc3T216o23a5Dt28Zj%2F8sOSo7%2BMrgO417Z49ANR%2F8RhZPw%3D%3D--8X%2B1G1VQi8oTaxaX--X%2B4esaNnc8dwAVs1rUdZtA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.811215454.1753611347; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:15:47 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 10:15:47 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E3F6:29FD1F:D0CB27:1146D13:6885FC53
Border to PreferenceView by dnenov · Pull Request #14078 · DynamoDS/Dynamo · GitHub
as instructed by @Amoursol. The only thing is the borderthickness, which for the Nodes is 1px, and for the PreferencesView is now set at 2px. I will double-check with @Amoursol to see if there is preference for each maybe.
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Border to PreferenceView #14078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 1 commit into
DynamoDS:master
from
dnenov:dnenov-preferencesviewborderupdate
Jun 15, 2023
Merged
Border to PreferenceView #14078
QilongTang
merged 1 commit into
DynamoDS:master
from
dnenov:dnenov-preferencesviewborderupdate
Jun 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added white border to preference view to increase visibility
|
The reported regression is sporadic failure |
QilongTang
reviewed
Jun 15, 2023
| <Grid x:Name="mainGrid" | ||
| Background="{StaticResource PreferencesWindowBackgroundColor}"> | ||
| <Border x:Name="mainBorder" | ||
| BorderBrush="{StaticResource WorkspaceBackgroundHomeBrush}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you happen to found out this color from other places is white?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this one from the NodeView border
| BorderBrush="{StaticResource WorkspaceBackgroundHomeBrush}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will merge it for now
QilongTang
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
A visual update to the Preferences View adding a white (
WorkspaceBackgroundHomeBrush) 2px border. This should increase the visibility of the control and make it easier for users to make out the actual window when overlapping with other UI elements.Screenshot of changes
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@Amoursol
@reddyashish
@QilongTang
FYIs