CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=336.581345,conversation_content-fragment;desc="conversation_content fragment";dur=649.228001,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=243.658603,nginx;desc="NGINX";dur=1.037215,glb;desc="GLB";dur=102.014245
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Jab9qUCg2IHxuH5i6j7BcCGI4ZWEU6KrDucQS8Aqy5xAr4YZRRxZFx7PeluBcWBzgF01E2sH8ut4kDC4Upx%2F%2Bu61Lkg9SRykvz2IYWu6OX9IHr84QcZQSF%2BMpwMdI7nbegqcNxj%2FAzamNeNee%2F%2FSyc0SMgtrbF5hwvW126N95SaxGcGcWNszOhCWcOiCaxgzexMaUmHLTWWSpXOjJXhncx08u9QvOBuK%2BAI%2BwVwtHfzKrysIIm%2F30o7zMAim2vGKuKwWwMdgAsHu7kmCRCaw6Q%3D%3D--ISbNp0KXKY2nDDIb--XJVIoQyyi2rq%2BG92eFh0wg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1836993742.1753593174; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 82EC:3E3773:17AFAB:23252E:6885B556
DYN-5795 Lucene Search Weights by RobertGlobant20 · Pull Request #14062 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
DYN-5795 Lucene Search Weights #14062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
QilongTang
merged 1 commit into
DynamoDS:master
from
RobertGlobant20:DYN-5795-Lucene-Search-Weights
Jun 13, 2023
Merged
DYN-5795 Lucene Search Weights #14062
QilongTang
merged 1 commit into
DynamoDS:master
from
RobertGlobant20:DYN-5795-Lucene-Search-Weights
Jun 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard-coded values for the field names were moved to the Configurations class and all the places in which this names were used were replaced. Also in the SearchViewModel.Search() method I've done minor changes to consider the wildcard expression * keyword *
reddyashish
approved these changes
Jun 13, 2023
QilongTang
reviewed
Jun 13, 2023
/// <summary> | ||
/// This represent the fields that will be indexed when initializing Lucene Search | ||
/// </summary> | ||
public enum IndexFieldsEnum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine place for now, I may move these to dedicated Lucene config file later in my PR
QilongTang
reviewed
Jun 13, 2023
wildcardQuery = new WildcardQuery(new Term(f, s + "*")); | ||
if (f.Equals("Name")) { wildcardQuery.Boost = 5; } | ||
else { wildcardQuery.Boost = 2; } | ||
wildcardQuery = new WildcardQuery(new Term(f, "*" + s + "*")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably could benefit with some comments
QilongTang
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Minor changes in the Lucene Search functionality
The hard-coded values for the field names were moved to the Configurations class and all the places in which this names were used were replaced. Also in the SearchViewModel.Search() method I've done minor changes to consider the wildcard expression * keyword *.
The next fields were removed: "InputParameters", "OutputParameters", "PackageName", "PackageVersion" due that are not used in the Legacy Search and neither in the Lucene search.
TODO - There is still a functionality that I think should be implemented (but not sure about it):


In the Legacy Search at indexing time each keyword (SearchKeywords) has assigned a specific weight between 0.0 - 1.0 (SearchKeywordsWeight) but when running the query those weights are used for sorting the results, in comparison, in the Lucene Search we are assigning a fixed weights for all the tags (see image attached), then for fixing this case we need to convert the SearchKeywords weights from 0.0-1.0 to 1 - 10 scale and set the right Boost value for each word, I think this should be implemented in the string CreateSearchQuery(string[] fields, string searchKey) method.
@reddyashish
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Minor changes in the Lucene Search functionality
Reviewers
@QilongTang @reddyashish
FYIs