You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this work with localized strings? Can you test that as well?
Do you mean when the tooltip is localized?
No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.
Does this work with localized strings? Can you test that as well?
Do you mean when the tooltip is localized?
No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.
Gotcha, do you recall which ones? I guess for @jesusalvino Please just sanity check other languages to see if the position is good
Does this work with localized strings? Can you test that as well?
Do you mean when the tooltip is localized?
No I mean when the preference option is localized, I saw some examples where when localized the location of the question mark will not change while the string is now longer than it is in English.
Gotcha, do you recall which ones? I guess for @jesusalvino Please just sanity check other languages to see if the position is good
@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.
@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.
Make sense, let's get this in now for 2.18 and work within team in bug bashes to see what needs to be adjusted
@Jingyi-Wen Looks like there is extra space between the label name and the icon. Probably reduce that a little? Also the icon is not center-aligned vertically in some cases.
Good catch! We definitely should have them center-aligned vertically. And agree with reducing the space, the icon next to the Max Number of Recent Files text box is a good reference
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implementing the improvement https://jira.autodesk.com/browse/DYN-5721
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@RobertGlobant20
@Enzo707