You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles). This fix is not applicable for the Color Palette node.
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles).
This fix is not applicable for the Color Palette node.
Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?
@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles).
It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).
Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?
@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles). It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).
Understood, I think both cases are what customer asked, please give it a check. Thanks!
This fix will be pre-populating the custom colors in CustomColorPicker (when opened from the Color Palette node) with the colors added in the Preferences->GroupStyles section.
Also I've added a unit test that will be validating that the custom colors list used by ColorPicker is populated correctly with the color loaded from Group Styles
Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?
@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles). It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).
Understood, I think both cases are what customer asked, please give it a check. Thanks!
@QilongTang functionality added for the Color Palette node and I've added a unit test. Thanks
see the next commit: 93d356e
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles). This fix is not applicable for the Color Palette node.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section.
Reviewers
@QilongTang
FYIs