| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:12:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=432.914943,conversation_content-fragment;desc="conversation_content fragment";dur=779.302554,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=316.41965,nginx;desc="NGINX";dur=1.609768,glb;desc="GLB";dur=101.260853
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=fqanJxUFztESBbR36KZg%2FSmx9pdiBbF9cBne%2Btu%2Fso%2BHtvcjrjzxhXQzwtN7ZPUcUlnmVWqMYqxblj2Cn1soHKNY%2B5QNzOhQJv46%2B0wukXi88fbNdT9pPF3WUl3HmH2MF1tbqf7eeL2PJUOftACxjiYFfGY3eQlSjb7yl2hFt11Be72bLezhEpMuNUkF6i6j17N45DrmdEioLaX1UVZn0RlghQy6awPq0cuQ%2F7rKs6HKUSVLCNrXO%2F1e5tBzjKZV%2FZ2JtV1X6MKLfQWhmgAZtw%3D%3D--trEyTXdPlnNmRuwt--K6RXmP9NxuHx%2FubZj%2Bc%2F2w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1445221583.1753593153; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:33 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:12:33 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EE26:2EF87B:64FF0A:882064:6885B541
Make Linter Extension and API public by saintentropy · Pull Request #13902 · DynamoDS/Dynamo · GitHub
saintentropy
changed the title
Make Linter Extension and API public (WIP)
Make Linter Extension and API public
Apr 24, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Make Linter Extension and API public #13902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
saintentropy
merged 3 commits into
DynamoDS:master
from
saintentropy:MakeLinterPublicAPI
Apr 24, 2023
Merged
Make Linter Extension and API public #13902
saintentropy
merged 3 commits into
DynamoDS:master
from
saintentropy:MakeLinterPublicAPI
Apr 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are a few more things : |
|
Thinking of the minimal exposure needed for the upcoming DA check rules I think we only need internal abstract class LinterExtensionBase from the list above so let's add that and then LGTM @saintentropy |
BogdanZavu
approved these changes
Apr 21, 2023
|
@saintentropy @BogdanZavu @twastvedt We are going to release Dynamo 2.18 soon, is this one required? |
|
@QilongTang Yes please |
|
@saintentropy Please cherry-pick this to RC branch as well then |
saintentropy
added a commit
to saintentropy/Dynamo
that referenced
this pull request
Apr 24, 2023
* Make Linter base case public * Typos * Missing base class to public --------- Co-authored-by: Craig Long <craig.long@autodesk.com> (cherry picked from commit 5f7f7ea)
saintentropy
changed the title
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Expose the LinterExtensionBase as a public base class so that user can create linter extensions to create rule sets for Dynamo graphs beyond the GenerativeDesign type.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@BogdanZavu .
FYIs
@mjkkirschner @twastvedt