| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 17:30:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=367.520863,conversation_content-fragment;desc="conversation_content fragment";dur=614.999307,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=289.551152,nginx;desc="NGINX";dur=0.718796,glb;desc="GLB";dur=101.206864
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=xjbVVUSz2Z1TQjhtZ7BR8Jspg5UqKM5gFQRIZLp4HezYxxIXlNjlyQcp%2BuP0gub1uj537WsDaVELj4%2F4LqlG1%2F8OuO5m5iKxAsNoCEFqFwifTQhkydS9VE18lBpTVAxAxatdK%2BTZY4EGTZ0YTz7tMEdr8WRSm6xJF3Z2yGyM97GB14J%2BSLHjXI3rharGW9fYdapDQn05ZHBLVHvGjt8uRSU8g6jJ5TXTZd1iXA4VqEjbOVnrVhuStBCSiOEqqdrEjKvCT91JPNxXylheSskdbA%3D%3D--hAcfPlM%2FT0Q2mkg7--QFth6suZw%2FXkbwNJv1CjIA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.478296415.1753637455; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:30:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:30:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8190:21EF6:6FAFF5:927D24:6886624F
Handle PortToConnect correctly, when same node recommendations are returned from ML API by reddyashish · Pull Request #13899 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Handle PortToConnect correctly, when same node recommendations are returned from ML API #13899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turned from ML API
Closed
9 tasks
|
Hi @reddyashish Is this PR just for the bug that clicking on each entry will connect to the right port instead? you mentioned that we cant implement the UI changes for sub menu items correct? |
|
Yes, just for that bug. |
1 similar comment
|
Yes, just for that bug. |
|
@QilongTang Only 1 flaky test now InsideCustomNode_NotPlacedInHomeWorkspace_NoGeometry. |
|
@reddyashish And we are still not sure which PR caused that flaky test right? Are you fine with Morpheus team merging PRs with new flaky tests? @mjkkirschner @sm6srw or would you rather us investigate this a bit more? |
|
Yeah not sure yet. Lets see the results from Mike's PR #13900, if any test fails |
QilongTang
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-5645
Now the correct port is connected when same node recommendations are returned from ML API. The results are displayed as list box and not as menu items. So we won't be able to provide sub menu functionality.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Handle PortToConnect correctly, when same node recommendations are returned from ML API
Reviewers
@QilongTang
FYIs
@DynamoDS/dynamo