| CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 02:17:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=393.072936,conversation_content-fragment;desc="conversation_content fragment";dur=853.47886,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=295.940813,nginx;desc="NGINX";dur=1.027569,glb;desc="GLB";dur=101.58267
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=AYAl0kNm16m%2Fa3RPa7M2ovDJvr1uNxzzvQrtYKAaeC5XDJCjaxAvRpVPCaXO5ffURDMmQLAmLuiScPwxHsRJTC9KcNqnqQyFP9wrpd6kYJmknUBrrgsUVQE3428e6WJQL282hTd%2FtlU4n6LlkTkylFEyr%2FArZcP0ILmGhfXNcKP0%2FScG537Gvt%2F6AYQyh%2FdKQhepDozAhhc6fzdD30e01WcFFGG%2F5ftPB6cXWWyVj9N9Im9w0RJYg42OMDtVcP7DK7sMifsMdsDALujwMwGtqg%3D%3D--gQWPcVRgPqHQ0dH0--R3CMXY4q%2FIS5zvPcyTiqew%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.416569366.1753669044; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:17:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 02:17:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C4FC:2E9E4D:5AFF9:8B5F7:6886DDB4
Bugfix - Live Chart Nodes Search Tags by dnenov · Pull Request #13843 · DynamoDS/Dynamo · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Bugfix - Live Chart Nodes Search Tags #13843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:bugfix-livecharts-searchtags
Mar 24, 2023
Merged
Bugfix - Live Chart Nodes Search Tags #13843
reddyashish
merged 3 commits into
DynamoDS:master
from
dnenov:bugfix-livecharts-searchtags
Mar 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
reviewed
Mar 22, 2023
src/Libraries/CoreNodeModelsWpf/Properties/CoreNodeModelWpfResources.en-US.resx
Outdated
Show resolved
Hide resolved
reddyashish
approved these changes
Mar 22, 2023
|
@reddyashish Side question, are search tags put into resources so that they can be surfaced in a localized env? |
The search tags are in resources @QilongTang , yes! |
This test is passing locally. I tried rebuilding the PR, but it popped up with 2 more failing tests. I might get a new PR from scratch based on the latest Dynamo build. |
reddyashish
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge once the self-serve finishes
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* Bugfix - search tags were duplicating the alsoknownas property causing an error to be thrown * Remove code that should not be part of the PR
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Bugfix - search tags were duplicating the alsoknownas property causing an error to be thrown * Remove code that should not be part of the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
A small PR modifying the Search Tags of a series of Nodes.
The recently added Live Chart nodes had duplicate information in Search Tags and the AlsoKnownAs node properties, which was causing an error to be thrown when adding the node information to the Search Dictionary. Changing the Search Tags solved this issue.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
search tagswere duplicating thealsoknownasproperty causing an error to be thrownReviewers
@mjkkirschner
@reddyashish
FYIs
@Amoursol