CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 20:28:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=372.500754,conversation_content-fragment;desc="conversation_content fragment";dur=1125.861556,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=310.191772,nginx;desc="NGINX";dur=1.719681,glb;desc="GLB";dur=102.663562
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=EuecpXAW%2FhfKr%2Bf6z3Uar9%2FNIeZksx9iMC%2BghToMiDJa%2BJOHXKeu0X88NxkhIoYkZM7p9CgGp%2FqyKfBP9xVERiY5NaN8VDE1VI7l%2Bvn%2BvNKHeVjQbp8NBe6%2BXpDvoNmQiCpQKNXgHJypcpoNfiw%2FMuDdfV8r4cIIRK5FmFTg22g3oP1uXUJuqKr7wP0GbEaoXZOnBMlYDwW3GXsALFzQDBAeqHu049pfMsAa5Vkvd1ay5%2FvTqGY%2FbGe%2F8wW6p3P7szHva2IzuoNr9OaQ9tjk8g%3D%3D--nvGofdRIP5%2FPvrHM--T%2Ftwp0ti0dXxRvrAmDuwqQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.708072627.1753561733; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:28:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 20:28:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8814:37D5F1:8BCFE7:B525EC:68853A85
Enable Locale Selection in Dynamo Preferences Panel by QilongTang · Pull Request #13802 · DynamoDS/Dynamo · GitHub
QilongTang
requested review from
RobertGlobant20,
Jingyi-Wen,
reddyashish and
zeusongit
March 7, 2023 23:13
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Enable Locale Selection in Dynamo Preferences Panel #13802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
reviewed
Mar 8, 2023
reddyashish
reviewed
Mar 8, 2023
reddyashish
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RobertGlobant20
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment
mjkkirschner
reviewed
Mar 8, 2023
sm6srw
pushed a commit
to sm6srw/Dynamo
that referenced
this pull request
Mar 29, 2023
* First Commit * Update locale on startup * spelling * dynamically display and select current locale * Clean up * Unit Tests * Add toast notification * Move constants out of PreferencesSetting object * Add info icon and tooltip * Update PreferenceSettingsTests.cs * Update test file * Remove interface change
sm6srw
pushed a commit
that referenced
this pull request
Apr 5, 2023
* First Commit * Update locale on startup * spelling * dynamically display and select current locale * Clean up * Unit Tests * Add toast notification * Move constants out of PreferencesSetting object * Add info icon and tooltip * Update PreferenceSettingsTests.cs * Update test file * Remove interface change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR enables Locale selection in Dynamo Preferences Panel. As a result, Dynamo will be localized in the new locale after a restart. Notice that the selection does not affect current Dynamo session.
User experience: (notice the new language selections resources are in DynamoCore not localized yet)

New info icon added
Toast notification added

Gif:

Serialization changes:

TODO:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Enable Locale Selection in Dynamo Preferences Panel
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of