You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does:
Added remaining projects to the dotnet6 build
Added new Pythonnet assemblies targeting netstandard2.0 (will remove when pythonnet PR is merged)
Fixed a bug with the way we search for ASM files on linux vs windows
Some small changes from @saintentropy
The reason will be displayed to describe this comment to others. Learn more.
I added new assemblies for netstd20 only because I could not get tests to run on the pythonnet targeting netstd20
Once we get pythonnet CICD to run properly, we can just keep the new netstd20 assmeblies (since they are compatible with net48 and net6.0)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does:
Added remaining projects to the dotnet6 build
Added new Pythonnet assemblies targeting netstandard2.0 (will remove when pythonnet PR is merged)
Fixed a bug with the way we search for ASM files on linux vs windows
Some small changes from @saintentropy