LGTM. The ML autocomplete request here https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs#L38 should be using these values from settings. Can you make that change as well and also resolve the conflicts.

LGTM. The ML autocomplete request here https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs#L38 should be using these values from settings. Can you make that change as well and also resolve the conflicts.

Done.

Looks good to me with one comment. The only test failing is the IfSubmenuOpenOnMouseHover which is flaky.

Looks good to me with one comment. The only test failing is the IfSubmenuOpenOnMouseHover which is flaky.

that test works for me locally

Yes that test was failing intermittently on master-5. We can ignore that.

The last job has this failing test [Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings]
Can you check it and lets run the job again,

The last job has this failing test [Dynamo.Tests.Configuration.PreferenceSettingsTests.TestImportCopySettings] Can you check it and lets run the job again,

Done.

Thanks @jesusalvino. We can merge this after the job gets finished. Once @QilongTang confirms if this can still get in for 2.17, we can cherry-pick it.