You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a graph from Dynamo Player while the Dynamo UI was open, the value and UI display of dropdown nodes was not updated consistently.
DropDown.UpdateValueCore uses the SelectedIndex setter instead of its own logic.
The DropDown.SelectedIndex setter runs RaisePropertyChanged("SelectedString"). (Previously it changed selectedString but did not alert the UI of the change.)
Opportunistic fixes:
The DropDown.SelectedString setter runs RaisePropertyChanged("SelectedIndex"). (Previously it changed selectedIndex but did not alert the UI of the change.)
The DropDown.SelectedString setter does nothing if the given value is the same as the current value.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes AGD-2777
When running a graph from Dynamo Player while the Dynamo UI was open, the value and UI display of dropdown nodes was not updated consistently.
DropDown.UpdateValueCore
uses theSelectedIndex
setter instead of its own logic.DropDown.SelectedIndex
setter runsRaisePropertyChanged("SelectedString")
. (Previously it changedselectedString
but did not alert the UI of the change.)Opportunistic fixes:
DropDown.SelectedString
setter runsRaisePropertyChanged("SelectedIndex")
. (Previously it changedselectedIndex
but did not alert the UI of the change.)DropDown.SelectedString
setter does nothing if the given value is the same as the current value.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@saintentropy