You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, Can we append some tests to serialize the new settings? I think we already have a preference setting somewhere so you only need to touch the settings.xml and update the test.
@QilongTang Added the BackupInterval and HardwareAcceleration property to the preferences-serialization tests. MaxNumRecentFiles is already added to this test and we have 2 separate tests for the loading of PythonTemplate. We also have a CanUpdatePythonTemplateSettings() test in the CoreTests class that checks: changing the PythonTemplate. So that should cover it.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the following settings to preferences panel. Serialize user preference.
https://jira.autodesk.com/browse/DYN-5203
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Add settings to preferences panel
Reviewers
@QilongTang @jesusalvino @Amoursol