| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 05:10:40 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=383.265397,conversation_content-fragment;desc="conversation_content fragment";dur=1044.317449,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=291.399555,nginx;desc="NGINX";dur=0.812173,glb;desc="GLB";dur=101.36426
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=jS%2BOHZMRRYyQXaljakR%2F1RRABlMJ%2BM5NnZYZZfhwAHjKoAgbRHWt3Di2XEVzBA5u0bhixeJYMWpF10jA3LDqCQp6LU6RMwu3t9qZWG%2F8FSyvk5fy9lqmoC0SChjjmIm4j63CpVt3DEDhCxFyAVbawH0psOhDP%2FelafMNh4R%2FQXvz0gmCphCQEgHg%2BRtc%2Bw6r7ahQHUxUiI039zD56jG9%2FyMxzhfPAhqDqgUnRTC7PFvY9nshNCqRXkfdPNRde8Qg6cLImR3vnzwzAjHzTz2Cig%3D%3D--Y5PEXDBRevfFmpcL--zf7bIFckKC6x6sPaulcUXA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1821905364.1753593039; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:10:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 05:10:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D390:3467EF:AE391E:E8373A:6885B4CF
don't initialize the direct manipulation extension when asm is not loaded by mjkkirschner · Pull Request #13219 · DynamoDS/Dynamo · GitHub
mjkkirschner
changed the title
wrap libg use in try catch
wrap direct manipulator libg use in try catch
Aug 15, 2022
mjkkirschner
changed the title
wrap direct manipulator libg use in try catch
don't initialize the direct manipulation extension when asm is not loaded
Aug 15, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
don't initialize the direct manipulation extension when asm is not loaded #13219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
changed the title
sm6srw
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pinzart90
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjkkirschner can we prevent loading the DM view extension altogether if ASM fails to preload? I think @QilongTang did this for the guided tour, if I'm not wrong.
aparajit-pratap
approved these changes
Aug 15, 2022
dont startup or call loaded on dm extension if asm not loaded
mjkkirschner
changed the title
|
thanks @aparajit-pratap for correcting my misunderstanding here - I attempted to resolve both suggestions you gave. |
|
tests passed on latest commit here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/6802/ |
| manipulatorDaemon = ManipulatorDaemon.Create(new NodeManipulatorFactoryLoader()); | ||
| } | ||
|
|
||
| public void Loaded(ViewLoadedParams viewLoadedParams) | ||
| { | ||
| if (!viewLoadedParams.StartupParams.IsGeometryLibraryLoaded) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the IsGeometryLibraryLoaded check in both Startup and Loaded functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'd like to avoid partially initializing as much as possible.
aparajit-pratap
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Dynamo crashes when LibG is not loaded and a direct manipulator is created.
https://jira.autodesk.com/browse/DYN-5023
IsASMLoadedis false.IsASMLoadedis accurate in all situations, it seems to really only be set in CLI or sandbox startup - but thats probably sufficient since in-process hosts preload ASM themselves in most cases.I will send another PR with a test - want to get this in first.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed crash when node was moved which was going to create direct manipulator.
Reviewers