| CARVIEW |
Select Language
HTTP/2 200
date: Sun, 27 Jul 2025 17:34:00 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=241.014527,conversation_content-fragment;desc="conversation_content fragment";dur=529.593599,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=251.384994,nginx;desc="NGINX";dur=0.376998,glb;desc="GLB";dur=114.220887
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=xOTu6aO0oUWFbYStxdgaezSNds%2BNY4RMXtwYYvmxpzxhDGHUNXXr0Hlx3VuEqwdlElxfiqHR%2BPU%2B6oHZAFebsc206fy5OYAwNlGKMMO7WM3gbWF2V%2BVCBwBiFy9xpnt05Z0myZqpPcXN6HR8XSpS%2BEGkygpFoPdC02fKivEEFqEgDQ%2FY63g3bISBH1Bn6ymuhT6P9rmNWfroqY%2BrqVP%2FFixsCXB7aKv8MRAuiMzb6KSHPf2ujcdGEWhBohDIbSPjewDUSjqdPZXecJJpxdEmVQ%3D%3D--cCRbQ6%2Fag5cqTzVJ--HqbqnuXsnK%2FfSgjhkfJcIQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.625752990.1753637639; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:33:59 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Mon, 27 Jul 2026 17:33:59 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 939E:0A77:41DE53:53564D:68866307
Cache if package maintainer is an author of the package to avoid multiple API calls by zeusongit · Pull Request #13111 · DynamoDS/Dynamo · GitHub
zeusongit
changed the title
Update PackageManagerClient.cs
Cache if package maintainer is an author of the package to avoid multiple API calls
Jul 14, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 658
Cache if package maintainer is an author of the package to avoid multiple API calls #13111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusongit
changed the title
|
do we check this again / refresh if the user logs out / logs in as another user? |
Not tested that scenario in revit, but it will break in that case, as Dictionary will have stale values. |
QilongTang
reviewed
Jul 14, 2022
QilongTang
reviewed
Jul 14, 2022
|
I checked in Revit, we cannot sign out without quitting, not sure about other integrators. @mjkkirschner
|
QilongTang
reviewed
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM does it make sense to add a unit test for this update?
Unit test is not helpful, as we call the parent method for result, internally it uses cached or API response, with no way of knowing the difference. |
QilongTang
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-5103
When a user right clicks a package in Dynamo package manager preference tab, we check if the user is an author of that package or not in order to enable/disable Deprecate/Undeprecate option for that package.
Created a cache in Dynamo to record the result so that we do not call the API again and again for one session.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Created a cache in Dynamo to record the result so that we do not call the API again and again for one session.
Reviewers
@QilongTang