DYN-4973-Popups-NotAttached #13002

RobertGlobant20 · 2022-06-14T18:54:47Z

Purpose

I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background).
I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour.
For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.

Declarations

Check these if you believe they are true

The codebase is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
All tests pass using the self-service CI.
Snapshot of UI changes, if any.
Changes to the API follow Semantic Versioning and are documented in the API Changes document.
This PR modifies some build requirements and the readme is updated

Release Notes

I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive.

Reviewers

@QilongTang

FYIs

I implemented the functionality of hiding/showing the FileTrustUI and GuidedTours popups when the Dynamo window is inactive (in background). I've tested the functionality for the User Interface tour and Packages tour and for the exitwindow that appear in the Packages tour. For the other tours the RealTimeWindow (that appear when exiting the Guide) wont' have this functionality implemented.

RobertGlobant20 · 2022-06-14T18:55:29Z

This GIF shows the functionality for the Popups in the Guided Tour

RobertGlobant20 · 2022-06-14T18:56:04Z

This GIF shows the functionality for the Popup in the FileTrustUI

zeusongit · 2022-06-14T18:58:37Z

Does this also fix toast notifications, are they also attached to parent window now?

RobertGlobant20 · 2022-06-14T19:17:49Z

Does this also fix toast notifications, are they also attached to parent window now?

@zeusongit
if you are talking about the RealtimeInfoWindow (see image below), no, it's just fixing the next Popups:

Guided Tours
File Trust UI
Search (ContextWindow appearing when clicking right over the Workspace)

For the RealTimeInfo popup I think @QilongTang changed the StaysOpen property in a different PR then it should be closing the Popup when the focus is lost.

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs

I removed all the functionality of setting a state in the Guide and also added a new event for when the tour is completely closed (just in the case of the Packages guide).

src/DynamoCoreWpf/Views/Core/DynamoView.xaml

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs

Changed the hard-coded string to use the static string

src/DynamoCoreWpf/Views/Core/WorkspaceView.xaml

src/DynamoCoreWpf/Views/Core/DynamoView.xaml.cs

src/DynamoCoreWpf/UI/GuidedTour/GuideFlowEvents.cs

QilongTang

Some comments, then LGTM

Event renamed from GuidedTourClosed to GuidedTourFinished. The property warningPopup was renamed to fileTrustWarningPopup.

Event renamed from GuidedTourFinished to GuidedTourExited

Fixing function name to match event name.

Removed subscriptions to GuidedTourExited event and the empty function handler.

src/DynamoCoreWpf/UI/GuidedTour/GuideFlowEvents.cs

Renaming property to IsGuideExited

After the changes done in the next PR: #13002 I introduced a bug that was not allowing to save the path added in trusted locations, then with this fix is saving again the trusted locations.

RobertGlobant20 requested review from QilongTang, zeusongit and reddyashish June 14, 2022 18:54

QilongTang reviewed Jun 14, 2022

View reviewed changes

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs Outdated Show resolved Hide resolved

QilongTang reviewed Jun 14, 2022

View reviewed changes

src/DynamoCoreWpf/UI/GuidedTour/GuidesManager.cs Outdated Show resolved Hide resolved

DYN-4973-Popups-NotAttached Code Review

d382ee7

I removed all the functionality of setting a state in the Guide and also added a new event for when the tour is completely closed (just in the case of the Packages guide).