You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
PRs will be reviewed from oldest to newest
If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.
Purpose
This PR implements visual improvements at node ports to indicate if a Function Node is in an active/inactive state.
A new rectangle was added in the output port to represent the active/inactive state.
Considering that Function State is represented by the boolean IsPartiallyApplied, here are how some states are working in the implementation of this PR.
State 1 - Function state but not passing a function (Output port is not connected to another node)
State 2 - Function passing (Output port is connected to another node and passing a function)
State 3 - All input ports are connected, so are not considered at function state anymore (Standard connected input colors)
State 4 - The input ports have default values, so it's not considered at function state (Standard connected input colors)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
This PR implements visual improvements at node ports to indicate if a Function Node is in an active/inactive state.
A new rectangle was added in the output port to represent the active/inactive state.
Considering that Function State is represented by the boolean
IsPartiallyApplied
, here are how some states are working in the implementation of this PR.State 1 - Function state but not passing a function (Output port is not connected to another node)
State 2 - Function passing (Output port is connected to another node and passing a function)
State 3 - All input ports are connected, so are not considered at function state anymore (Standard connected input colors)
State 4 - The input ports have default values, so it's not considered at function state (Standard connected input colors)
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @mjkkirschner
FYIs
@jesusalvino @RobertGlobant20